Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

END_OF_TRANSMISSION code may miss the old embedded source magic #14

Open
martinwork opened this issue Jun 6, 2018 · 0 comments
Open

Comments

@martinwork
Copy link

In the code-review branch...

The code burns 64 bytes at the final flashPointer = offset, but then adds 1024 to flashPointer before starting the search for the magic. Although the final page should have been erased, if the final offset is part way through the page, the search will start part way through the next page, unless it is rounded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant