You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just realised microbit_free checks for a NULL pointer, so in normal circumstances it won't crash, but deleting a NULL pointer still seems wrong!
And sizeof(RebootMode) should be sizeof(RebootModeValue).
martinwork
changed the title
MicroBitBLEManager::restartInBLEMode() could crash
MicroBitBLEManager::restartInBLEMode() uses the wrong size for RebootModeValue
Jun 12, 2018
On branch "code-review"...
RebootMode is deleted when it is NULL. When it's non-NULL, RebootMode leaks, though this doesn't matter much as the next line is a reset.
sizeof(RebootMode) should be sizeof(RebootModeValue).
The text was updated successfully, but these errors were encountered: