Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to API docs containing periods result in a 403 #1099

Open
microbit-matt-hillsdon opened this issue Feb 6, 2023 · 1 comment
Open
Assignees

Comments

@microbit-matt-hillsdon
Copy link
Collaborator

Bug Description

This works: https://python.microbit.org/v/3/api/gc
This does not: https://python.microbit.org/v/3/api/microbit.audio.SoundEffect (403 forbidden)

Presumably a glitch in the fallback routing that we have to serve the index page. Probably needs fixing outside this repo but tracking here.

@microbit-matt-hillsdon
Copy link
Collaborator Author

The routing function is using the presence of a dot in the final part to avoid sending the HTML of the app on the assumption it's an asset path. We either need a different rule or we change these URLs. As they've never worked that seems to be an option. E.g. s/[.]/-/g ? Or perhaps / ?

https://python.microbit.org/v/3/api/microbit/audio/SoundEffect seems like it makes perfect sense.

@microbit-matt-hillsdon microbit-matt-hillsdon self-assigned this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant