Wrap entire try block in queueMicrotask

microbit-foundation · Nov 28, 2024 · 9127e5c · 9127e5c
1 parent c5b9427
commit 9127e5c
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/editor/codemirror/language-server/signatureHelp.ts b/src/editor/codemirror/language-server/signatureHelp.ts
@@ -91,18 +91,18 @@ const triggerSignatureHelpRequest = async (
   try {
     // Must happen before other event handling that might dispatch more
     // changes that invalidate our position.
-    queueMicrotask(() => {
+    queueMicrotask(async () => {
+      const result = await client.connection.sendRequest(
+        SignatureHelpRequest.type,
+        params
+      );
       view.dispatch({
-        effects: [setSignatureHelpRequestPosition.of(pos)],
+        effects: [
+          setSignatureHelpRequestPosition.of(pos),
+          setSignatureHelpResult.of(result),
+        ],
       });
     });
-    const result = await client.connection.sendRequest(
-      SignatureHelpRequest.type,
-      params
-    );
-    view.dispatch({
-      effects: [setSignatureHelpResult.of(result)],
-    });
   } catch (e) {
     if (!isErrorDueToDispose(e)) {
       logException(state, e, "signature-help");