Skip to content

Commit 2ec757a

Browse files
microbit-matt-hillsdonmicrobit-robertmicrobit-grace
authored
Apply suggestions from code review
Co-authored-by: Robert Knight <[email protected]> Co-authored-by: Grace <[email protected]>
1 parent a704380 commit 2ec757a

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/documentation/search/search-client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const workerForLanguage = (language: string) => {
6060
// See also convertLangToLunrParam
6161

6262
// Enumerated for code splitting as Vite doesn't support dynamic strings here
63-
// We use a worker per language for because Vite doesn't support using dynamic
63+
// We use a worker per language because Vite doesn't support using dynamic
6464
// import in a iife Worker and Safari doesn't support module workers.
6565
switch (language.toLowerCase()) {
6666
case "de": {

src/fs/host-default.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { defaultInitialProject } from "./initial-project";
99
import { testMigrationUrl } from "./migration-test-data";
1010

1111
describe("DefaultHost", () => {
12-
it.skip("uses migration if available", async () => {
12+
it("uses migration if available", async () => {
1313
const project = await new DefaultHost(
1414
testMigrationUrl
1515
).createInitialProject();

src/fs/migration.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { isMigration, parseMigrationFromUrl } from "./migration";
77
import { testMigrationUrl } from "./migration-test-data";
88

9-
describe.skip("parseMigrationFromUrl", () => {
9+
describe("parseMigrationFromUrl", () => {
1010
it("parses valid URL", () => {
1111
const migration = parseMigrationFromUrl(testMigrationUrl);
1212
expect(migration).toEqual({

src/language-server/pyright.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const pyright = async (
3636
return undefined;
3737
}
3838
if (cache) {
39-
// This is safe to called if already initialized.
39+
// This is safe to call if already initialized.
4040
await cache.client.initialize();
4141
if (cache.language === language) {
4242
return cache.client;

0 commit comments

Comments
 (0)