Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop checking for the append-script marker in filesystem operations #22

Closed
microbit-carlos opened this issue May 7, 2020 · 1 comment

Comments

@microbit-carlos
Copy link
Collaborator

Right now, it is constantly checking the micropython hex string to see if it has the old marker to append a script to a known flash address: :::::::::::::::::::::::::::::::::::::::::::

It's not a lot of processing, but the hex strings can be large and we are trying to increase performance.

The hex string provided to the MicropythonFsHex constructor should be correctly formed, and that should be the responsibility of the caller (like the Python Editor).

@microbit-carlos microbit-carlos changed the title Stop checking for the appende-script marker in filesystem operations Stop checking for the append-script marker in filesystem operations May 11, 2020
@microbit-carlos
Copy link
Collaborator Author

Done in a418ade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant