From 382dc119f15600e1e7b098bcfbe8f114d465c324 Mon Sep 17 00:00:00 2001
From: r59q <andreashenriksen@yahoo.dk>
Date: Tue, 9 Jul 2024 21:22:57 +0200
Subject: [PATCH 1/2] Disabled training page tabs when knn model is disabled

---
 .../training/KnnModelTrainingPageView.svelte  |  2 +-
 .../training/TrainingPageModelView.svelte     |  7 +-
 src/pages/training/TrainingPageTabs.svelte    | 69 +++++++++++++------
 src/script/utils/graphUtils.ts                |  5 +-
 4 files changed, 56 insertions(+), 27 deletions(-)

diff --git a/src/pages/training/KnnModelTrainingPageView.svelte b/src/pages/training/KnnModelTrainingPageView.svelte
index 9fd3dd543..18d1b2f27 100644
--- a/src/pages/training/KnnModelTrainingPageView.svelte
+++ b/src/pages/training/KnnModelTrainingPageView.svelte
@@ -61,7 +61,7 @@
   {#if $filters.length == 2}
     <KnnModelGraph />
   {:else}
-    <div class="m-auto">
+    <div class="max-w-[450px] flex flex-col justify-center">
       <p class="max-w-80 text-md font-bold text-center">
         {$t('menu.trainer.knn.onlyTwoFilters')}
       </p>
diff --git a/src/pages/training/TrainingPageModelView.svelte b/src/pages/training/TrainingPageModelView.svelte
index c92f0d616..bdb8ba2a8 100644
--- a/src/pages/training/TrainingPageModelView.svelte
+++ b/src/pages/training/TrainingPageModelView.svelte
@@ -10,11 +10,16 @@
   import KnnModelTrainingPageView from './KnnModelTrainingPageView.svelte';
   import ModelRegistry from '../../script/domain/ModelRegistry';
   import NeuralNetworkTrainingPageView from './NeuralNetworkTrainingPageView.svelte';
+  import { Feature, hasFeature } from '../../script/FeatureToggles';
+
+  const showFilterList = hasFeature(Feature.KNN_MODEL);
 </script>
 
 <div class="flex flex-col h-full justify-center">
   <div class="flex flex-row p-2">
-    <FiltersList />
+    {#if showFilterList}
+      <FiltersList />
+    {/if}
     {#if $selectedModel.id === ModelRegistry.KNN.id}
       <KnnModelTrainingPageView />
     {:else if $selectedModel.id === ModelRegistry.NeuralNetwork.id}
diff --git a/src/pages/training/TrainingPageTabs.svelte b/src/pages/training/TrainingPageTabs.svelte
index 3c82fdd97..97e2d4709 100644
--- a/src/pages/training/TrainingPageTabs.svelte
+++ b/src/pages/training/TrainingPageTabs.svelte
@@ -4,9 +4,18 @@
   SPDX-License-Identifier: MIT
  -->
 <script lang="ts">
+  import StandardButton from '../../components/buttons/StandardButton.svelte';
   import ControlBar from '../../components/control-bar/ControlBar.svelte';
+  import { navigate, Paths } from '../../router/paths';
   import ModelRegistry from '../../script/domain/ModelRegistry';
+  import { Feature, hasFeature } from '../../script/FeatureToggles';
   import { selectedModel } from '../../script/stores/uiStore';
+  import { t } from '../../i18n';
+
+  const showTabBar = hasFeature(Feature.KNN_MODEL);
+  if (!showTabBar) {
+    $selectedModel = ModelRegistry.NeuralNetwork;
+  }
 
   const onSelectNeuralNetwork = () => {
     $selectedModel = ModelRegistry.NeuralNetwork;
@@ -19,25 +28,43 @@
   };
 </script>
 
-<ControlBar expanded shadows={false}>
-  <div class="flex flex-row flex-grow h-full">
-    <!--Left controlbar-->
-    <div
-      on:click={onSelectNeuralNetwork}
-      class:to-secondary={isSelected('NN')}
-      class:to-primary={!isSelected('NN')}
-      class:shadow-md={!isSelected('NN')}
-      class="flex flex-col border-l-2 border-b-2 border-secondary justify-center cursor-pointer h-full self-center flex-1 bg-gradient-to-r via-primary from-primary text-secondarytext">
-      <p class="text-center font-bold">Neural Network</p>
-    </div>
-    <!--Right controlbar-->
-    <div
-      on:click={onSelectKnn}
-      class:to-secondary={isSelected('KNN')}
-      class:to-primary={!isSelected('KNN')}
-      class:shadow-md={!isSelected('KNN')}
-      class="flex border-r-2 border-b-2 border-secondary flex-col justify-center cursor-pointer h-full self-center flex-1 bg-gradient-to-l via-primary from-primary text-secondarytext">
-      <p class="text-center font-bold">KNN Model</p>
+{#if showTabBar}
+  <ControlBar expanded shadows={false}>
+    <div class="flex flex-row flex-grow h-full">
+      <!--Left controlbar-->
+      <div
+        on:click={onSelectNeuralNetwork}
+        class:to-secondary={isSelected('NN')}
+        class:to-primary={!isSelected('NN')}
+        class:shadow-md={!isSelected('NN')}
+        class="flex flex-col border-l-2 border-b-2 border-secondary justify-center cursor-pointer h-full self-center flex-1 bg-gradient-to-r via-primary from-primary text-secondarytext">
+        <p class="text-center font-bold">Neural Network</p>
+      </div>
+      <!--Right controlbar-->
+      <div
+        on:click={onSelectKnn}
+        class:to-secondary={isSelected('KNN')}
+        class:to-primary={!isSelected('KNN')}
+        class:shadow-md={!isSelected('KNN')}
+        class="flex border-r-2 border-b-2 border-secondary flex-col justify-center cursor-pointer h-full self-center flex-1 bg-gradient-to-l via-primary from-primary text-secondarytext">
+        <p class="text-center font-bold">KNN Model</p>
+      </div>
     </div>
-  </div>
-</ControlBar>
+  </ControlBar>
+{:else}
+  <ControlBar>
+    <div class="min-h-12" />
+    <StandardButton
+      fillOnHover
+      small
+      outlined
+      bold={false}
+      shadows={false}
+      color={'primary'}
+      onClick={() => {
+        navigate(Paths.FILTERS);
+      }}>
+      {$t('content.trainer.controlbar.filters')}
+    </StandardButton>
+  </ControlBar>
+{/if}
diff --git a/src/script/utils/graphUtils.ts b/src/script/utils/graphUtils.ts
index 9bb805a8d..85a78eaac 100644
--- a/src/script/utils/graphUtils.ts
+++ b/src/script/utils/graphUtils.ts
@@ -124,7 +124,4 @@ export const distanceBetween = (point1: Point3D, point2: Point3D): number => {
   return Math.sqrt(squaredDistance);
 };
 
-export type LossTrainingIteration = {
-  loss: number;
-  epoch: number;
-};
+

From cf4d8bfa1976a5bffbec86b6f7320c8bae703428 Mon Sep 17 00:00:00 2001
From: r59q <andreashenriksen@yahoo.dk>
Date: Tue, 9 Jul 2024 21:26:09 +0200
Subject: [PATCH 2/2] Prettier

---
 src/script/utils/graphUtils.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/script/utils/graphUtils.ts b/src/script/utils/graphUtils.ts
index 85a78eaac..80105acb6 100644
--- a/src/script/utils/graphUtils.ts
+++ b/src/script/utils/graphUtils.ts
@@ -123,5 +123,3 @@ export const distanceBetween = (point1: Point3D, point2: Point3D): number => {
 
   return Math.sqrt(squaredDistance);
 };
-
-