From 64f82402500488697cf48b436065297948689f23 Mon Sep 17 00:00:00 2001
From: r59q <andreashenriksen@yahoo.dk>
Date: Mon, 25 Mar 2024 22:02:58 +0100
Subject: [PATCH] Added warning for ineffective KNN model

---
 src/pages/training/TrainModelButton.svelte | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/pages/training/TrainModelButton.svelte b/src/pages/training/TrainModelButton.svelte
index 5b313b13f..ab1bfc337 100644
--- a/src/pages/training/TrainModelButton.svelte
+++ b/src/pages/training/TrainModelButton.svelte
@@ -6,7 +6,7 @@
 
 <script lang="ts">
   import { t } from '../../i18n';
-  import { classifier } from '../../script/stores/Stores';
+  import { classifier, gestures } from '../../script/stores/Stores';
   import LayersModelTrainer from '../../script/mlmodels/LayersModelTrainer';
   import StaticConfiguration from '../../StaticConfiguration';
   import StandardDropdownButton from '../../components/buttons/StandardDropdownButton.svelte';
@@ -28,6 +28,7 @@
     highlightedAxis,
   } from '../../script/stores/uiStore';
   import Axes from '../../script/domain/Axes';
+  import Logger from '../../script/utils/Logger';
 
   export let onTrainingIteration: (iteration: LossTrainingIteration) => void;
   export let onClick: () => void;
@@ -35,6 +36,20 @@
   const getModelTrainer = (modelEntry: ModelEntry): ModelTrainer<MLModel> => {
     if (modelEntry.id === 'KNN') {
       highlightedAxis.set(Axes.X);
+      const noOfRecordings = gestures
+        .getGestures()
+        .map(gesture => gesture.getRecordings().length)
+        .reduce((prev, cur) => cur + prev, 0);
+
+      if (noOfRecordings / 2 < StaticConfiguration.knnNeighbourCount) {
+        Logger.log(
+          'TrainModelButton',
+          'The number of recordings is probably too low for an effective KNN model if using ' +
+            StaticConfiguration.knnNeighbourCount +
+            ' neighbours ',
+        );
+      }
+
       return new KNNModelTrainer(StaticConfiguration.knnNeighbourCount);
     }