Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signature of MultiResNDTiffAPI.increaseMaxResolution #141

Open
nicost opened this issue Oct 28, 2023 · 1 comment
Open

Change signature of MultiResNDTiffAPI.increaseMaxResolution #141

nicost opened this issue Oct 28, 2023 · 1 comment

Comments

@nicost
Copy link
Member

nicost commented Oct 28, 2023

Is it OK to change the signature of MultiResNDTiffAPI

void increaseMaxResolutionLevel(int newMaxResolutionLevel);

to:

Future<Integer> increaseMaxResolutionLevel(int newMaxResolutionLevel);

where Integer denotes the newMaxResolutionIndex?

This would make it possible to immediately display the new resolution image, rather than having to wait for a user action to update the UI. Currently, in Magellan in Explore mode, zooming out regularly leads to a completely black canvas that only gets filled in when the user moves the mouse. or otherwise forces the display to update.

@henrypinkard
Copy link
Member

Yes, and that makes sense. Here are all the places where it is used, which (maybe?) you would need to update. Though maybe not because they can just discard the future it returns

Screen Shot 2023-11-02 at 8 47 46 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants