Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please tag the release commits #106

Open
bnavigator opened this issue Apr 1, 2023 · 3 comments
Open

Please tag the release commits #106

bnavigator opened this issue Apr 1, 2023 · 3 comments

Comments

@bnavigator
Copy link

From a packager viewpoint it would be great if you add git tags to the commits used for releasing a version on PyPI. For example, I need the test files corresponding to the released sdist.

@henrypinkard
Copy link
Member

Seems reasonable. Though I've never done it. Do you know how to do this/automate it? Interested in submitting a PR? Probably it should go in the automated build script action

@bnavigator
Copy link
Author

Tagging / Releasing

Tag for a past release: https://git-scm.com/book/en/v2/Git-Basics-Tagging.

 git tag -a  e7e32f7 v1.12.0
 git push origin v1.12.0

Or even easier, make a release using the button on the Website:
image

image

Automation

If I read your workflow correctly, you update PyPI on every push to the main branch changing _version.py. You could change that to a trigger when you make a new release
Along with that you could manage _version.py with setuptools_scm.

@henrypinkard
Copy link
Member

Thanks for the info!

It sounds like (unlike me) you are quite familiar with how all the python packaging stuff works. I was vaguely aware this repo uses an older version, but I never had time to dig into updating/upgrading it. If you are interested in making a Pull request that updates this, I'd be happy to merge it

If I read your workflow correctly, you update PyPI on every push to the main branch changing _version.py

Yes, that's right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants