Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I see no way to add an XY stage position other than the default one to an AcquisitionEvent #116

Open
nicost opened this issue Apr 10, 2024 · 1 comment

Comments

@nicost
Copy link
Member

nicost commented Apr 10, 2024

It seems that the desired position of the default XY stage are set through the setX() and setY() functions. The default Z stage can be set using setZ(). Other stages (also including the default Z Stage ?) can be set through setStageCoordinate(String, double). However, there is no corresponding setXYStageCoordinate(String, double, double).

How are non-default XY stages handled? Also, what is the relation between setZ() and setStageCoordinate(String, double)?

@henrypinkard
Copy link
Member

setStageCoordinate(String, double) was added after setZ() to, as you say, support non-default z stages. Obviously there's a possibility of a collision when you setStageCoordinate on the default stage. I can't remember how I resolved this (should be easy to find in the code), but I remember being unsure about what the correct behavior should be.

You're right, there's no setXYStageCoordinate(String, double, double). I've never encountered a microscope with multiple XY stages, so I never had a reason to add it. You could add it if you want.

If you do want to add something or have an idea of what the correct default behavior should be for one of both of those, you should write a test in pycromanager to ensure that it doesn't get broken in the future. Happy to advise more on how to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants