Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice in README needs a wee update #41

Open
paul-hammant opened this issue Sep 1, 2023 · 2 comments
Open

Advice in README needs a wee update #41

paul-hammant opened this issue Sep 1, 2023 · 2 comments

Comments

@paul-hammant
Copy link

README currently says "You can run the container on its own", but I think it needs 'content' running (default port 5000) or else there's an immediate can't find React error.

After that though, there's a missing 'http://localhost:5000/restaurants.json' resource (same port) and now I'm confused to whether I'm correct with the above suggested advise.

Maybe shouldn't be looking at the chrome tab that 'yarn start' itself opens at all.

@maxgabut
Copy link

maxgabut commented Sep 7, 2023

I think you're right about 'container' needing 'content'. It's the later that serves React to the former.

Regarding restaurant.json, it's necessary to run yarn build in the 'content' project to generate it.

@camjackson
Copy link
Contributor

Yes you're correct, the content app needs to be running for anything to be functional. The readme does say:

You can run the container on its own, but for it to actually do anything you'll also need to be running:

Happy to take a PR if anyone has a better suggested wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants