From 696c798df77b4ebb34ac22cbac8f24765d942316 Mon Sep 17 00:00:00 2001
From: Michael Hawkins <michaelh@moodle.com>
Date: Mon, 26 Aug 2024 12:10:21 +0800
Subject: [PATCH] fixup! MDL-81732 smsgateway_aws: Add hooks for SMS gateway
 management

---
 sms/gateway/aws/classes/hook_listener.php  | 7 ++++++-
 sms/gateway/aws/lang/en/smsgateway_aws.php | 4 +---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/sms/gateway/aws/classes/hook_listener.php b/sms/gateway/aws/classes/hook_listener.php
index 2d0906dc1d6b6..4717f10faf444 100644
--- a/sms/gateway/aws/classes/hook_listener.php
+++ b/sms/gateway/aws/classes/hook_listener.php
@@ -75,11 +75,12 @@ public static function set_form_definition_for_aws_sms_gateway(after_sms_gateway
             'maxlength="255" size="20"',
         );
         $mform->setType('api_key', PARAM_TEXT);
+        $mform->addRule('api_key', get_string('required'), 'required', null, 'client');
+        $mform->addRule('api_key', get_string('maximumchars', '', 255), 'maxlength', 255);
         $mform->setDefault(
             elementName: 'api_key',
             defaultValue: '',
         );
-
         $mform->addElement(
             'passwordunmask',
             'api_secret',
@@ -87,6 +88,8 @@ public static function set_form_definition_for_aws_sms_gateway(after_sms_gateway
             'maxlength="255" size="20"',
         );
         $mform->setType('api_secret', PARAM_TEXT);
+        $mform->addRule('api_secret', get_string('required'), 'required', null, 'client');
+        $mform->addRule('api_secret', get_string('maximumchars', '', 255), 'maxlength', 255);
         $mform->setDefault(
             elementName: 'api_secret',
             defaultValue: '',
@@ -99,6 +102,8 @@ public static function set_form_definition_for_aws_sms_gateway(after_sms_gateway
             'maxlength="255" size="20"',
         );
         $mform->setType('api_region', PARAM_TEXT);
+        $mform->addRule('api_region', get_string('required'), 'required', null, 'client');
+        $mform->addRule('api_region', get_string('maximumchars', '', 255), 'maxlength', 255);
         $mform->setDefault(
             elementName: 'api_region',
             defaultValue: 'ap-southeast-2',
diff --git a/sms/gateway/aws/lang/en/smsgateway_aws.php b/sms/gateway/aws/lang/en/smsgateway_aws.php
index 746af20b8f47a..8218d4d4125e9 100644
--- a/sms/gateway/aws/lang/en/smsgateway_aws.php
+++ b/sms/gateway/aws/lang/en/smsgateway_aws.php
@@ -30,6 +30,4 @@
 $string['aws_information'] = 'Complete the following fields using the information provided by AWS';
 $string['pluginname'] = 'AWS';
 $string['privacy:metadata'] = 'The AWS SMS gateway plugin does not store any personal data.';
-$string['usecredchain'] = 'Find AWS credentials using the default credential provider chain';
-
-
+$string['usecredchain'] = 'Find AWS credentials using the default provider chain';