Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix application.js example. (Highcharts Error #16) #239

Closed
wants to merge 1 commit into from
Closed

Fix application.js example. (Highcharts Error #16) #239

wants to merge 1 commit into from

Conversation

michaelbrawn
Copy link

@michaelbrawn michaelbrawn commented Jul 28, 2017 •
edited
Loading

Fix README.md application.js example. (Highcharts Error #16)

This resolves #206.

Fiddle Example.

@michaelbrawn
Copy link
Author

michaelbrawn commented Jul 28, 2017 •
edited
Loading

According to the highchart's error message, this should be the fix. I am seeing an error loading highcharts-more using the gem that I'm not seeing in the fiddle example given, when loading from Highchart's CDN.

highcharts-more.self-3013bd0….js?body=1:22 Uncaught TypeError: r is not a function
    at highcharts-more.self-3013bd0….js?body=1:22
    at highcharts-more.self-3013bd0….js?body=1:27
    at highcharts-more.self-3013bd0….js?body=1:9
    at highcharts-more.self-3013bd0….js?body=1:9
(anonymous) @ highcharts-more.self-3013bd0….js?body=1:22
(anonymous) @ highcharts-more.self-3013bd0….js?body=1:27
(anonymous) @ highcharts-more.self-3013bd0….js?body=1:9
(anonymous) @ highcharts-more.self-3013bd0….js?body=1:9

I've confirmed Loading the most recent version of highstock using the CDN resolves this issue.

HTML

<script src="//code.highcharts.com/stock/highstock.js"></script>

application.js

//= require highcharts/highcharts-more

@michelson
Copy link
Owner

Hi @michaelbrawn , thanks for this contribution

so , I guess we could not merge this until we fix that ?

@michaelbrawn
Copy link
Author

That's probably best. This should wait until the gem is updated to the current version of highstock js and this is verified.

@nalabjp nalabjp mentioned this pull request Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uncaught exception: Highcharts error #16: www.highcharts.com/errors/16
2 participants
@michaelbrawn @michelson