diff --git a/Acquire/Gromacs/_gromacs_runner.py b/Acquire/Gromacs/_gromacs_runner.py index c03f4a6..02dddd4 100644 --- a/Acquire/Gromacs/_gromacs_runner.py +++ b/Acquire/Gromacs/_gromacs_runner.py @@ -235,7 +235,26 @@ def run(bucket): # now unpack this file with _tarfile.open(input_tar_bz2, "r:bz2") as tar: - tar.extractall(".") + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, ".") # remove the tar file to save space _os.remove(input_tar_bz2)