Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file_target_extension option as redundant #23

Open
michalfita opened this issue Dec 28, 2023 · 1 comment
Open

Remove file_target_extension option as redundant #23

michalfita opened this issue Dec 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@michalfita
Copy link
Owner

Problem

All board files define "file_target_extension" option that except one case¹ is equal to the filename of the downloaded image. That option feeds Extension member of StepDownload, however, looking into the code shows that this is supposed to append an extension to downloaded file without one, what should never be the case. Even the Jetson's image loads attachement with .zip extension, so it can always be derived.

I personally failed at this option couple times dealing with my board files (that aren't and can't be public).

Resolution

Removal or making this optional (I don't think we need this complexity) would make use of this plugin easier for users.


¹ - that file is jetson-nano/ubuntu.json

@michalfita michalfita added the enhancement New feature or request label Dec 28, 2023
@michalfita michalfita added this to the Usage Simplification milestone Dec 28, 2023
@michalfita
Copy link
Owner Author

Note: looking at the code looks like this option is already redundant and optional. Needs some experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant