Apply suggestions from code review

style: add more info to changelog, remove unnecessary whitespace. Co-authored-by: Nicholas Felt <[email protected]> Signed-off-by: Mike Wagoner <[email protected]>
michaelwagoner · Feb 8, 2024 · e666aa9 · e666aa9
1 parent c1e4cd9
commit e666aa9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -33,7 +33,7 @@ Things to be included in the next release go here.
 ### Fixed
 
 - Fixed the code that detects VISA resource expressions to be able to detect SOCKET resource expressions properly.
-- Fixed PI device close method to catch VisaIOErrors and throw a warning closing a PI device connection.
+- Fixed PI device close method to catch VisaIOErrors and throw a warning, rather than an exception, when closing a PI device connection.
 
 ______________________________________________________________________
 

diff --git a/src/tm_devices/drivers/pi/pi_device.py b/src/tm_devices/drivers/pi/pi_device.py
@@ -822,7 +822,7 @@ def _close(self) -> None:
             self._visa_resource.close()
         except VisaIOError as error:
             warnings.warn(
-                f"Error encountered while closing the visa resource: \n {error}", stacklevel=2
+                f"Error encountered while closing the visa resource:\n{error}", stacklevel=2
             )
         self._visa_resource = None  # pyright: ignore[reportAttributeAccessIssue]
         self._is_open = False