Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gridfinity insert base #17

Open
mmalecki opened this issue Jan 20, 2025 · 1 comment
Open

Add Gridfinity insert base #17

mmalecki opened this issue Jan 20, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@mmalecki
Copy link

mmalecki commented Jan 20, 2025

I was wondering if you'd be open to accepting a pull request to add a Gridfinity insert base class for building just the profile, on which others could then build their own not-boxy inserts, and on which the GridfinityBox could then be refactored to build upon.

What I mean is facilities for building the following example:

Image

In order to achieve the effect of generating just the base, I created a GridfinityBox and called just render_shell(as_solid = True) on it. I'm just looking for a cleaner solution here for folks who come after me. This also doesn't work with magnet holes, etc., for which I had to hack render_shell to return early before cutting, and go back to calling render()

mmalecki added a commit to mmalecki/cq-gridfinity that referenced this issue Jan 23, 2025
The library needed a little editing in order to render just the base.

I note that doing this from the grounds up probably would have been
easier, but I'm just really lazy.

Ref michaelgale#17
@michaelgale michaelgale added the enhancement New feature or request label Jan 23, 2025
@michaelgale
Copy link
Owner

Hi! Thanks for the suggestion on rendering just a base solid. I think its a good idea and I agree it would be better to implement it more cleanly than hacking the GridfinityBox class render methods. Let me think on this and see if there's a way of doing it more elegantly. It might offer the opportunity to clean up some other things in GridfinityBox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants