Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX objective missing a constant term when D>16 #2

Open
michaelchughes opened this issue Mar 11, 2015 · 0 comments
Open

FIX objective missing a constant term when D>16 #2

michaelchughes opened this issue Mar 11, 2015 · 0 comments

Comments

@michaelchughes
Copy link
Owner

This does NOT affect the quality of the cluster centers and/or sample assignments. Just the computed value of the objective function.

In pairwise_distance()" function in KMeansRexCore.cpp. When D > 16 you do not add the norm of the data points to the distance matrice. The fix is to insert the following line as the last line of the "else" case:
Dist.colwise() += X.square().rowwise().sum().col(0);

Reported by Sobhan ([email protected])

@michaelchughes michaelchughes changed the title FIX FIX objective missing a constant term when D>16 Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant