Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear 'x' icon not removed when showClearButton=false #330

Open
dmoebius opened this issue May 25, 2023 · 1 comment
Open

clear 'x' icon not removed when showClearButton=false #330

dmoebius opened this issue May 25, 2023 · 1 comment

Comments

@dmoebius
Copy link

Bug Report

Environment

  • Extension version(s): 6.1.19
  • Bulma version: 0.9.4
  • OS: any
  • Browser: all

Current Behavior
setting option showClearButton only removes the button "Clear" inside the panel. But it does not remove the "x" icon, so the field is still clearable.

Possible Solution
Inside src/js/templates/index.js the button class="datetimepicker-clear-button" is always shown. It must be dependent on the showClearButton flag.
@FrancoisOfSos
Copy link

+1

dmoebius added a commit to meta-system-GmbH/bulma-calendar that referenced this issue Aug 17, 2023
@dmoebius
fix: showClearButton=true now removes the x icon in the input field, …
1dc665e 
…too (michael-hack#330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmoebius @FrancoisOfSos