Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify FMLAT for access transformer in MANIFEST.MF, instead of using custom Access Transformer class (for better dev environment compatibility) #2817

Closed
Barteks2x opened this issue Jun 8, 2017 · 3 comments
Closed

Specify FMLAT for access transformer in MANIFEST.MF, instead of using custom Access Transformer class (for better dev environment compatibility) #2817

Barteks2x opened this issue Jun 8, 2017 · 3 comments

Comments

@Barteks2x
Copy link

Barteks2x commented Jun 8, 2017 •
edited
Loading

I tried to run galacticraft in dev environment, but I found that it crashes as soon as I run /dimensiontp, it was caused by a difference in used mappings. Galacticraft currently applies special deobf access transformer on it's own, which seems to be useless now. After I removed the deobf AT, moved the existing one manually to META-INF and specified FMLAT entry in MANIFEST.MF the mod ran just fine.

I can try to submit PR for that if needed.
@Barteks2x
Copy link
Author

The issue should go to https://github.com/micdoodle8/MicdoodleCore/issues, I didn't notice it's separate repository

@EzerArch
Copy link
Contributor

EzerArch commented Jun 8, 2017

You can close this one here and reopen there. :)

@Barteks2x
Copy link
Author

Barteks2x commented Jun 8, 2017 •
edited
Loading

Ok. It's here

@Barteks2x Barteks2x mentioned this issue Jun 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Barteks2x @EzerArch