You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I use caddy-dynamicdns to enable ddns on my private network/VPN (via Tailscale). Unfortunately, the change in #61 regresses my use case since private IPs are no longer returned by ip_source interface.
I'm able to work around this with a custom caddy module to provide a new IPSource. However, after seeing @jm355 call out my exact use case #59 (comment)_ I wanted to track this for posterity should anyone else run into this!
@Monviech's suggestion in #59 to include a include_private_ips flag sounds good to me. I'm happy to get started on a PR, unless maintainers have a better idea 🙂
The text was updated successfully, but these errors were encountered:
I'm not sure what happens if both a public and private ip gets returned. Based on the name include_private_ips, I'm guessing it would return both, so maybe calling it something else like only_private_ips and only returning a private ip might be better? Just a minor nitpick/pointer, and it's been a while since I looked at this so I'm not sure
Hello!
I use caddy-dynamicdns to enable ddns on my private network/VPN (via Tailscale). Unfortunately, the change in #61 regresses my use case since private IPs are no longer returned by
ip_source interface
.I'm able to work around this with a custom caddy module to provide a new
IPSource
. However, after seeing @jm355 call out my exact use case #59 (comment)_ I wanted to track this for posterity should anyone else run into this!@Monviech's suggestion in #59 to include a
include_private_ips
flag sounds good to me. I'm happy to get started on a PR, unless maintainers have a better idea 🙂The text was updated successfully, but these errors were encountered: