Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide option to include private IP addresses #74

Open
tylervick opened this issue Sep 6, 2024 · 3 comments
Open

provide option to include private IP addresses #74

tylervick opened this issue Sep 6, 2024 · 3 comments

Comments

@tylervick
Copy link

Hello!

I use caddy-dynamicdns to enable ddns on my private network/VPN (via Tailscale). Unfortunately, the change in #61 regresses my use case since private IPs are no longer returned by ip_source interface.

I'm able to work around this with a custom caddy module to provide a new IPSource. However, after seeing @jm355 call out my exact use case #59 (comment)_ I wanted to track this for posterity should anyone else run into this!

@Monviech's suggestion in #59 to include a include_private_ips flag sounds good to me. I'm happy to get started on a PR, unless maintainers have a better idea 🙂

@mholt
Copy link
Owner

mholt commented Sep 6, 2024

Heh, I guess that will work then. 👍 Want to submit a PR?

@jm355
Copy link
Contributor

jm355 commented Sep 6, 2024

I'm not sure what happens if both a public and private ip gets returned. Based on the name include_private_ips, I'm guessing it would return both, so maybe calling it something else like only_private_ips and only returning a private ip might be better? Just a minor nitpick/pointer, and it's been a while since I looked at this so I'm not sure

@mholt
Copy link
Owner

mholt commented Sep 6, 2024

Good point. It's almost like you'd need to toggle public/private, but not have both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants