-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this project dead? Need Graph API backend and token username is also broken. #368
Comments
The last commit was 3 months ago, and the last time the owner replied to an issue was 1 month ago. You consider that to be a long time? Seriously? This project isn't anyone's full-time job. The project owner works on it when he can and when he wants to. If that's not good enough for you, then feel free to contribute some patches or start your own open source project. Also, please learn how to format your GitHub posts properly. |
1-3 months is long. Code needs an overhaul. I gave the info if you'd like to patch. I don't need to start an open source project to solve this problem. My time is limited too, but I'm glad you can read. |
Anyways.. when you use the email value instead of unique_name, it works around the first bug, generates a cookie with much more info but then later complains about the and invalid login. This looks like another bug where it might be confusing domains between office365.com and live.com (versus letting user specify in settings). That's true especially if the user gets redirected to office.live.com anyway. That's about 2 bugs now. I wonder who tests on this project these days? davmail.exchange.auth.O365Token - Authenticated user [email protected] from stored token |
The DavMail project has been around a long, long time in internet years, and the maintainer has weathered all the storms so far. One impatient user shouting and stamping their feet probably isn't going to motivate him one way or the other. However, that said… @ttesty I was like you once. Come and re-read what you wrote in this issue in a year, or in five years, and see how much you've grown. One day, hopefully soon, you'll come to understand what a thankless job it is to maintain an open source project, maybe after you start your own. |
That's the problem - the project isn't consistently maintained and the QA coverage appears limited. Your so-called impatient user and other garbage-worthy characterizations won't motivate anyone. If you open your eyes, you will see multiple users complaining in the issues filed about a lot of the same stuff. I'm probably the first patient user that offered a fix (I was patient enough to rummage through unmaintained code on a presumably dead project). I don't have to re-read what I wrote in 1, 5 years or whatever, nor do I need to start an open source project. I came here to report a bug, a fix, while shocked that the project looks dead/unmaintained. So once again, take your own advice. |
I don't speak for the maintainer(s), but just as a user for some ten years or more, who has also rummaged through code and reported bugs. I just took a slightly different tack than you. Good luck with this approach. I wish you well. |
Thanks for your feedback and thanks @ernstki and @esabol for your support. As you may have noticed I tried to initiate a new backend dedicated to the "new" "modern" graph API provided by Microsoft. Among them : there is no way to create a mail from MIME body without the Draft flag... and the Draft is readonly after create. Anyway back to @ttesty, it looks like you are trying to use a live.com account? Can you please offer this as a patch so me and others can test it and confirm it's working before merging? Thank you, |
Project hasn't been updated in a long time. OAuth2 is no good for "modern" Outlook access anymore. Microsoft 365 Online (Business) costs at least $6/month to add Entra's app-based API Permissions to use Outlook 365 API (Personal). Graph API is the only free way, but it's not really implemented in davmail... And there's no local web host to handle https responses from redirect_url. Need POP3 Proxy->Graph API (Outlook 365/Exchange).
Tried:
problem: davmail - Can't find resource for bundle java.util.PropertyResourceBundle, key Authenticated username live.com#[email protected] does not match [email protected]. It's mixing up: "unique_name":"live.com#[email protected]" and complaining about it not matching "email":"[email protected]".
Token: {"aud":"d3590ed6-52b3-4102-aeff-aad2292ab01c","iss":"https://sts.windows.net/3ceb7ded-6237-4abf-aed0-f741fb55330a/","iat":X,"nbf":X,"exp":X,"altsecid":"1:live.com:X","amr":["pwd"],"email":"[email protected]","family_name":"X","given_name":"X","idp":"live.com","idtyp":"user","ipaddr":"X","name":"X","oid":"X","puid":"X","rh":"","sub":"","tid":"X","unique_name":"live.com#[email protected]","ver":"1.0","xms_idrel":"4 1"}
.... username = tokenBody.getString("unique_name");
?
You could check "email" field too... or parse on unique_name... past #
========================= token = O365Token.build(tenantId, clientId, redirectUri, code, password);
// get username from id_token
String idToken = jsonToken.optString("id_token");
if (idToken != null && idToken.contains(".")) {
String decodedJwt = IOUtil.decodeBase64AsString(idToken.substring(idToken.indexOf("."), idToken.lastIndexOf(".")));
try {
JSONObject tokenBody = new JSONObject(decodedJwt);
LOGGER.debug("Token: " + tokenBody);
username = tokenBody.getString("unique_name");
} catch (JSONException e) {
LOGGER.warn("Invalid id_token " + e.getMessage(), e);
}
}
The text was updated successfully, but these errors were encountered: