Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextInput to specify the country #22

Open
mgonzalezg9 opened this issue Apr 22, 2024 · 4 comments
Open

Add TextInput to specify the country #22

mgonzalezg9 opened this issue Apr 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@mgonzalezg9
Copy link
Owner

Add an Input in which the user can specify the country the city is located at

@mgonzalezg9 mgonzalezg9 added the bug Something isn't working label Apr 22, 2024
@Ahmad-Zahid
Copy link

@mgonzalezg9 can you share details? can I pick this up?

@mgonzalezg9
Copy link
Owner Author

@mgonzalezg9 can you share details? can I pick this up?

Yes, of course. Any help is well received :)

@Ahmad-Zahid
Copy link

@mgonzalezg9 can you share the details for this? i.e where exactly are we implementing this in our current system?

Thanks

@mgonzalezg9
Copy link
Owner Author

mgonzalezg9 commented Apr 22, 2024

@Ahmad-Zahid The bug here comes when a user tries to get the weather at a city which is located in several countries.
For example you can try searching "Ontario". Ontario is a city in Canada and also a city in California (USA).

So the idea is to add another text input behind the City title to optionally specify the country we want to look at.

I added some Openweather API tests for your information. Please find them at tests root folder.
Also take a look to Openweather official documentation to specify the search country and community posts.

When you finish you can submit your PR and I'll review and merge if it proceeds :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants