New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing parentheses around paragraph in paper #75

Closed

matt-graham opened this issue Jul 8, 2021 · 0 comments · Fixed by #78

matt-graham commented Jul 8, 2021

Submitting as part of JOSS review openjournals/joss-reviews#3397

ecological-inference/paper/paper.md

Line 61 in 2d47262

    
           (In several of these cases, `PyEI` includes modifications to the models as originally proposed in the cited literature, such as reparametrizations or other changes to upper levels of the hierarchical models in order to ease sampling difficulties.)

The parentheses around this paragraph (lines 45–47 in the proof PDF) is, I think, unnecessary and interrupts the flow of the paper.

karink520 mentioned this issue

Joss updates #78

Merged

gabeschoenbach closed this as completed in #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment