feat: fix autoclose bug in Home and add support of virtual close (or not) #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxity
commented
Jun 2, 2024
| @@ -238,15 +241,16 @@ export const setupGarageDoorOpener = ( | |||
| assignCurrentDoorState(CurrentDoorState.OPEN); | |||
| if (autoCloseDelay) { | |||
| await waitFor(`${deviceId}.pending`, autoCloseDelay); | |||
| assignCurrentDoorState(CurrentDoorState.CLOSED); | |||
| const targetDoorState = service.getCharacteristic(Characteristic.TargetDoorState); | |||
There was a problem hiding this comment.
This would trigger a new emit and re run in .on(CharacteristicEventTypes.SET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses a bug where HomeKit hangs during the auto-close delay sequence described here
Changelog:
Tests:
on my local setup using
npm linkfix #152