-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Holding CTRL or SHIFT prevents left- and right-clicking (attacking / using) when Amecs is installed #3774
Comments
Thanks for the report! |
Unbinding all of JEI's keybinds appears to resolve the issue.
Interestingly, if I bind SHIFT + LEFT-CLICK to something unrelated to JEI - opening the player's inventory, for example - everything works fine. However, if I use the same key combination for a control added by JEI, the issue I originally described returns. @Siphalor, do you have any ideas? As an aside - why doesn't JEI just use the vanilla |
Thank you, that's a helpful find. I think the issue must be with JEI's integration. JEI has a concept of "context" that allows for keybinds to avoid conflicts between different GUIs for example. To support that, the JEI integration with AMECS has some custom logic on top. |
I have debugged this deeply and found the source of the bug and some unexpected things as well. Built into the vanilla game: If you're on a mac, holding control will convert left-click into right-click. When a key and modifier are pressed, AMECS tries to find all keys that exactly match. This seems to happen with any keybinds, really. It's not specific to JEI's keybind implementation. If I bind shift-click to open the inventory then my inventory opens instead of breaking the block. |
I have recreated this same issue in 1.20.1 using only these mods:
|
@nycki93 That makes sense, as Amecs API is embedded in Mouse Wheelie. |
Steps to Reproduce the Bug
Expected Behavior
The player's hand swings as they attack whatever is in front of them
Actual Behavior
Nothing happens - it's as if the left-clicking is ignored
Mod Pack URL (Optional)
N/A
Mod Pack Version (Optional)
N/A
Extra Notes (Optional)
Likely related to this commit: c844479
latest.log
https://gist.github.com/unilock/cafa3cc3aadf5bb30646c9f399c0954c
The text was updated successfully, but these errors were encountered: