Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy Version Requires to be <= 1.23.5 #13

Closed
LandonSwartz opened this issue Jul 14, 2023 · 6 comments
Closed

Numpy Version Requires to be <= 1.23.5 #13

LandonSwartz opened this issue Jul 14, 2023 · 6 comments

Comments

@LandonSwartz
Copy link

For lbc.extract_topology(), there is a use of np.bool that does not execute if the numpy version is over 1.23.5. The np.bool value is deprecated after 1.20 and not able to be used after 1.23.5. Great work though.

@meyerls
Copy link
Owner

meyerls commented Jul 15, 2023

Hi @LandonSwartz,

I assume the error is caused by the package mistree. To fix the error I have created a pull request but it has not been merged yet.

A current fix can be found on my forked version: https://github.com/meyerls/mistree. Just install mistree from source and the error should be gone.

Did it work out?

@meyerls meyerls closed this as completed Jul 15, 2023
@LandonSwartz
Copy link
Author

Yes it did work out, I just uninstall mistree and set the numpy version to <= 1.23.5 and reinstalled. Works great! Very hopeful you can implement the L1 medial skeleton. I have tried and failed many times to do it in python.

@SamBum92
Copy link

This repo https://github.com/meyerls/mistree is mistree 1.2.1
This one https://github.com/knaidoo29/mistree is mistree 1.2.2
When install, pip inform that actual pc-skeletor (1.0.0) is in conflict with these versions:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pc-skeletor 1.0.0 requires mistree==1.2.0, but you have mistree 1.2.1 which is incompatible.

but it seems to work

@EGuney-1
Copy link

EGuney-1 commented Jun 4, 2024

This did not solve the issue for me, am still getting the following error message when pip is installing mistree: ModuleNotFoundError: No module named 'numpy'.

I have tried this both on Windows 11 and Ubuntu 20.04.4 LTS. I have tried it with Python versions 3.10, 3.11 and 3.12 and made sure to install NumPy with version <=1.23.5 first. I have tried all these by manually cloning mistree, both with the current version 1.2.2 and with the version 1.2.1 that was forked.

Do you have any ideas what else the cause of this may be?

@meyerls
Copy link
Owner

meyerls commented Jun 4, 2024

What is your specific error? Have you tried reinstalling numpy? Did you install my version of mistree?

@EGuney-1
Copy link

EGuney-1 commented Jun 4, 2024

Thanks for the swift response, yes I have started over from a clean venv a couple times, made sure to install the aforementioned NumPy version and also tried your fork of mistree. I always end up with the same error below:

image

(It is clear that this issue is related to mistree and not this repository, but I've seen someone else raise the same issue but the author of mistree just said he doesn't know and left it at that :/. So I don't want to take much of your time, let me know if potential solutions come to mind, if not I'll have to look for alternatives. Thanks in advance.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants