Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inherit_param_estimates: revisit rounding and use matrix-handling PR #684

Open
barrettk opened this issue May 3, 2024 · 1 comment
Open

Comments

@barrettk
Copy link
Collaborator

barrettk commented May 3, 2024

We were recently made aware of the fact that final estimates as returned from model_summary() may not be suitable for specification via inherit_param_estimates() due to the possibility of rounding impacting positive-definiteness for matrix-type records. We currently round values on top of that too.

The open matrix-handling PR (#656) has a lot of handling for this type of thing (checks for positive definiteness before/after rounding, and attempts to make matrices positive-definite if not). Especially given that inherit_param_estimates() might start to get a lot more use via the upcoming bootstrap feature, I think we'll want to add some of those checks/corrections to here as well (currently only part of tweak_param_estimates())

@barrettk barrettk added the bootstrap Bootstrap development label May 3, 2024
@barrettk
Copy link
Collaborator Author

barrettk commented May 3, 2024

Though technically not related to the bootstrap feature, im adding the label of bootstrap to make sure we think about this around the same time as the release of this feature (can still be a subsequent release). cc @seth127

@seth127 seth127 removed the bootstrap Bootstrap development label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants