:ref fing unqualified keyword throws :invalid-ref

[andrewzhurov]

(m/validate [:schema {:registry {:init-evt [:map {:closed true}]
                                 :deep-evt [:map {:closed true} [:prev-evt [:ref :evt]]]
                                 :evt      [:multi {:dispatch (comp some? :prev-evt)}
                                            [true :deep-evt]
                                            [false :init-evt]]}}
             :evt]
            {})
;; => #error {:message ":malli.core/invalid-ref", :data {:type :malli.core/invalid-ref, :message :malli.core/invalid-ref, :data {:ref :evt}}}

(m/validate [:schema {:registry {::init-evt [:map {:closed true}]
                                 ::deep-evt [:map {:closed true} [:prev-evt [:ref ::evt]]]
                                 ::evt      [:multi {:dispatch (comp some? :prev-evt)}
                                             [true ::deep-evt]
                                             [false ::init-evt]]}}
             ::evt]
            {})
;; => true

I guess throwing wasn't intended, as :ref can be used with strings (so not required to have refs qualified)

[opqdonut]

Currently malli only allows strings, vars and qualified symbols/keywords. This is probably to avoid conflicting with the built-ins.

malli/src/malli/core.cljc

Line 191 in bc80f3f

(defn -reference? [?schema] (or (string? ?schema) (qualified-ident? ?schema) (var? ?schema)))

[andrewzhurov]

@opqdonut thanks for the link.

This is probably to avoid conflicting with the built-ins.

Hm, presently one may set a custom schema under a :keyword that some built-in schema usually uses.
Is there some custom handling of schema based on the name a schema's given?
I'd assume it does not matter how you name things, the content that the name refers to contributes to semantics.

If not, perhaps would be best to shown a warn/error at the step where you try to register.
"The name you want to use for this schema has special meaning in malli and would hamper its work, try another one"
And allow :keyword names that are not colliding.

[opqdonut]

Yeah the docs and the error messages could be better here, agreed. I don't know why bare keywords are not allowed for refs. @ikitommi is probably the only one who knows.

[ikitommi]

Originally, just qualified keywords were supported, in align with Clojure Spec. Strings were added later as they do not clash with any built-ins. Now that the built-in schemas also can be qualified (e.g. :time/instant), I think the restriction could be loosened and to support any kind of value as reference. Not sure on what would be effects on this in general, Malli starts to be kinda large codebase, so might need attention somewhere else. Good that we have good test coverage :)

[ikitommi]

But, currently, a feature.