Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split reading into init and separate read call #48

Closed
jgriesfeller opened this issue Oct 21, 2024 · 4 comments
Closed

split reading into init and separate read call #48

jgriesfeller opened this issue Oct 21, 2024 · 4 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@jgriesfeller
Copy link
Member

In order to get pyaerocom's issue metno/pyaerocom#1301 done, we need to split the reading into two calls:

  • Init of the reader class
  • do the actual reading

This is needed so that revisions can be checked e.g. for caching on pyaerocom's side.

@jgriesfeller jgriesfeller self-assigned this Oct 21, 2024
@heikoklein
Copy link
Member

Sorry, what pyaerocom calls caching is providing a separate unified fast reader class.

If a pyaro-reader is too slow, it should be replaced by a fast pyaro-reader, e.g. netcdf-rw. pyaro should not need caching.

@jgriesfeller
Copy link
Member Author

jgriesfeller commented Oct 21, 2024

This is also to avoid reading the data twice as it is done now. I don't think we should really read data via class init. Not sure yet how that will work...
On top we tend to implement filtering in the reading classes now (for speed). Not sure how all of that fits together yet.
To be discussed and to be seen.

@heikoklein
Copy link
Member

I agree that there should not be any heavy reading during the init, and pyaro does not require that. It is up to the pyaro-reader to decide when and where it reads the data, and some might require to read all files to get any information.

@jgriesfeller jgriesfeller linked a pull request Oct 29, 2024 that will close this issue
@jgriesfeller jgriesfeller added the wontfix This will not be worked on label Nov 7, 2024
@jgriesfeller
Copy link
Member Author

Will not be implemented. just read on first data access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants