From 0bc13a2277cc325ec52c213dbac7ee9c937fc881 Mon Sep 17 00:00:00 2001
From: Jan Griesfeller <jang@met.no>
Date: Wed, 26 Feb 2025 12:57:09 +0100
Subject: [PATCH] WIP: assume that the given ebas_unit is the right one for now

---
 src/pyaro_readers/actrisebas/ActrisEbasReader.py | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/pyaro_readers/actrisebas/ActrisEbasReader.py b/src/pyaro_readers/actrisebas/ActrisEbasReader.py
index fd05291..b11dce1 100644
--- a/src/pyaro_readers/actrisebas/ActrisEbasReader.py
+++ b/src/pyaro_readers/actrisebas/ActrisEbasReader.py
@@ -322,6 +322,7 @@ def _read(
                 for s_idx, site_name in enumerate(urls_to_dl):
                     assert site_name
                     self._metadata[site_name] = {}
+
                     for f_idx, thredds_url in enumerate(urls_to_dl[site_name]):
                         _local_file_flag = False
                         if self.cache_flag:
@@ -373,7 +374,6 @@ def _read(
                         ):
                             logger.info(f"url {url} not read. Outside of time bounds.")
                             continue
-
                         # write cache file if needed
                         if self.cache_flag and not _local_file_flag:
                             # some of the data files can't be read by xarray due to errors. So we
@@ -407,6 +407,14 @@ def _read(
                                 log_str = f"station {site_name}, file #{f_idx}: found matching standard_name {std_name}"
                                 logger.info(log_str)
 
+                            # check units...
+                            netcdf_unit = tmp_data[_data_var].attrs["units"]
+                            ebas_unit = tmp_data[_data_var].attrs["ebas_unit"]
+                            if netcdf_unit != ebas_unit:
+                                logger.error(
+                                    f"var {_data_var} unit mismatch: unit arr: {netcdf_unit}; ebas_unit attr: {ebas_unit} for URL {url}")
+
+
                             # assert f"station {site_name}, file #{f_idx}: found matching standard_name {std_name}"
                             long_name = tmp_data.attrs["ebas_station_name"]
                             stat_code = tmp_data.attrs["ebas_station_code"]
@@ -527,7 +535,10 @@ def get_ebas_valid_flags(self, url: str = EBAS_FLAG_URL) -> dict:
     def get_ebas_data_units(self, tmp_data, var_name):
         """small helper method to get the ebas unit from the data file"""
         unit = tmp_data[var_name].attrs["units"]
-        return unit
+        ebas_unit = tmp_data[var_name].attrs["ebas_unit"]
+        if unit != ebas_unit:
+            logger.error(f"Error: mismatch between units {unit} and ebas_unit {ebas_unit} attributes")
+        return ebas_unit
 
     def get_ebas_data_standard_name(self, tmp_data, var_name):
         """small helper method to get the ebas standard_name for a given variable from the data file"""