Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyaro valley floor filter in emep config #1472

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Pyaro valley floor filter in emep config #1472

merged 6 commits into from
Jan 8, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jan 7, 2025 •
edited
Loading

Change Summary

Configuration for pyaro valley floor filter in reporting_base.py.

Related issue number

closes #1457

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2025-01 milestone Jan 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (d07f1a3) to head (7dad10c).
Report is 24 commits behind head on main-dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##           main-dev    #1472      +/-   ##
============================================
- Coverage     78.50%   78.47%   -0.04%     
============================================
  Files           139      139              
  Lines         21101    21113      +12     
============================================
+ Hits          16565    16568       +3     
- Misses         4536     4545       +9
Flag Coverage Δ
unittests 78.47% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review January 8, 2025 08:38
@thorbjoernl thorbjoernl requested a review from heikoklein January 8, 2025 08:39
@thorbjoernl
Copy link
Collaborator Author

This should in principle work now. Final run started but will take a while. Readying it now in case it should be included in today's release.

@thorbjoernl thorbjoernl merged commit 0b84ba2 into main-dev Jan 8, 2025
7 of 8 checks passed
@thorbjoernl thorbjoernl deleted the pyaro-filter-in-emep-config branch January 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heikoklein heikoklein heikoklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
m2025-01
Development

Successfully merging this pull request may close these issues.

Use valley-floor altitude filter in emep-config
2 participants
@thorbjoernl @heikoklein