From 09c6bcfcb2cc76498a70a7cbe9bca6c4b3d13d35 Mon Sep 17 00:00:00 2001 From: Manuel Carrer Date: Mon, 2 Dec 2024 13:22:43 +0100 Subject: [PATCH] Rework comments --- migrations/kvalobs/db/base_config.go | 1 - migrations/kvalobs/dump/main.go | 13 +++---------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/migrations/kvalobs/db/base_config.go b/migrations/kvalobs/db/base_config.go index 743a8a99..8a301ac5 100644 --- a/migrations/kvalobs/db/base_config.go +++ b/migrations/kvalobs/db/base_config.go @@ -24,7 +24,6 @@ type BaseConfig struct { } func (config *BaseConfig) ShouldProcessLabel(label *Label) bool { - // (config.Ts == nil || slices.Contains(config.Ts, ts.ID)) || return utils.IsEmptyOrContains(config.ParamIds, label.ParamID) && // utils.IsEmptyOrContains(config.Stations, label.StationID) && utils.IsEmptyOrContains(config.TypeIds, label.TypeID) && diff --git a/migrations/kvalobs/dump/main.go b/migrations/kvalobs/dump/main.go index ae641bf9..e2530739 100644 --- a/migrations/kvalobs/dump/main.go +++ b/migrations/kvalobs/dump/main.go @@ -5,16 +5,9 @@ import ( "migrate/utils" ) -// Same timeseries could be in both 'data' and 'text_data' tables -// First of all, why? -// Second, do we care? -// func readDataAndText(label *lard.Label, pool *pgxpool.Pool, config *DumpConfig) Data { -// // Supposed to join text anf number data to single slice -// return nil -// } -// -// TODO: not sure what to do with this one -// func joinTS(first, second []lard.Label) +// TODO: there were some comments in the original script about +// the fact that the same timeseries could be in both +// 'data' and 'text_data' type Config struct { db.BaseConfig