Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag functionality doesn't work anymore #115

Closed
CAMOBAP opened this issue Aug 28, 2021 · 5 comments
Closed

Tag functionality doesn't work anymore #115

CAMOBAP opened this issue Aug 28, 2021 · 5 comments
Assignees
@CAMOBAP

Comments

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Aug 28, 2021

https://github.com/metanorma/metanorma-docker/runs/3448129073?check_suite_focus=true#step:7:17

cc @ronaldtse
@CAMOBAP CAMOBAP self-assigned this Aug 28, 2021
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Aug 28, 2021

Looks like it happens after b584782

To be continued...

@ronaldtse
Copy link
Contributor

The Makefile has to be updated, but I think the right solution is to revert the removal of squash. The docker build squash option flattens the image completely, but we don’t really want that. Let me do the revert there.

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Aug 28, 2021

but I think the right solution is to revert the removal of squash

ok

I think the issue why it fails because we don't do tag before push

@ronaldtse will it be ok, if I will push this tiny fix to make CI green?

@ronaldtse
Copy link
Contributor

Of course! Please proceed.

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Aug 28, 2021

Fixed, rest will be addressed with #113

@CAMOBAP CAMOBAP closed this as completed Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronaldtse @CAMOBAP