Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF: Show version number (e.g. v3.01) in Concise summary #282

Closed
ronaldtse opened this issue Jan 3, 2025 · 3 comments
Closed

PDF: Show version number (e.g. v3.01) in Concise summary #282

ronaldtse opened this issue Jan 3, 2025 · 3 comments
Assignees
@Intelligent2013
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

The v3.01 string is somehow not rendered in this document (type: guide) but the version is shown in the SI Brochure.

Originally posted by @ronaldtse in #280 (comment)
@ronaldtse ronaldtse changed the title Show version number (e.g. v3.01) in Concise summary PDF: Show version number (e.g. v3.01) in Concise summary Jan 3, 2025
@ronaldtse ronaldtse added the enhancement New feature or request label Jan 3, 2025
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Jan 3, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma Jan 3, 2025
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Jan 3, 2025
@Intelligent2013
BIPM xslt updated for version rendering, metanorma/bipm-si-brochure#282
5ce4e8f
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Jan 3, 2025
@Intelligent2013
Merge pull request #792 from metanorma/bipm_update
6d5b972 
BIPM xslt updated for version rendering, metanorma/bipm-si-brochure#282
@Intelligent2013
Copy link
Contributor

This bug is 5 years old. The code for the 'guide' internal cover page added 5 years ago and didn't changed until now (metanorma/metanorma-bipm#58), the sample original PDF didn't have the draft version, and I mistakenly decided that draft version should be omitted.

Fixed now:
image

@Intelligent2013 Intelligent2013 moved this from 🌋 Urgent to ✅ Done in Metanorma Jan 3, 2025
@ronaldtse
Copy link
Contributor Author

Thank you very much

@ronaldtse
Copy link
Contributor Author

It is actually strange to call it draft, it is really a version within the edition. This is something that we need to address.

@ronaldtse ronaldtse mentioned this issue Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Intelligent2013 Intelligent2013

Labels
enhancement New feature or request
Projects
Metanorma
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronaldtse @Intelligent2013