Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll results "nextPageOffset" serialization error #11

Open
sfitts opened this issue Jul 10, 2023 · 2 comments
Open

Scroll results "nextPageOffset" serialization error #11

sfitts opened this issue Jul 10, 2023 · 2 comments

Comments

@sfitts
Copy link

sfitts commented Jul 10, 2023

Currently this is typed as a Long, but QDrant 1.3.1 is returning String (appears to be a UUID).

@sfitts
Copy link
Author

sfitts commented Jul 10, 2023

The offset property of PointsScrollRequest has a similar issue. This one however is a bit more complex since it wants either an integer or a UUID. Giving it a non-UUID string results in:

{
    "status": {
        "error": "Format error in JSON body: value 0 is not a valid point ID, valid values are either an unsigned integer or a UUID at line 1 column 24"
    },
    "time": 0.0
}

Their documentation certainly implies that they return an Integer as well, but that doesn't appear to be true.

@Jotschi
Copy link
Contributor

Jotschi commented Jul 11, 2023

The current version of the client only supports Qdrant v1.2.0 - Unfortunately the API is not versioned and this makes backwards compatibility hard to achieve. I have not yet worked on v1.3.x support.

I'm not sure whether they changed the datatype but this has happened in the past. Changes such as these unfortunately can break the client implementation.

Jotschi added a commit that referenced this issue Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants