forked from hashicorp/terraform-provider-aws
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
provider: Update default development and testing to Go 1.13
Reference: hashicorp#9992 Reference: hashicorp#10054 The main change here (and impetus because it seems to use too much memory in Go 1.12 for TravisCI to successfully pass linting) is upgrading github.com/golangci/golangci-lint to v1.18.0, which has fixes for Go 1.13 support in its listed dependencies. It was upgraded via: ```console $ go get github.com/golangci/[email protected] $ go mod tidy $ go mod vendor ``` The addition of `go 1.13` to the `go.mod` file signals that this module should be built with that version of Go or later. Different than Go 1.12, any Go 1.13 command run against the module will always add that versioning information to the go.mod file. We add this once now to prevent unnecessary Git differences in the future. Development, testing, and building with Go 1.12 and earlier should not be affected as we are not introducing any breaking changes at the moment, but we do not officially support versions other than what is tested against via TravisCI. As a simple verification of the above statement: ```console $ go1.12 version go version go1.12.9 darwin/amd64 $ go1.12 test ./... ? github.com/terraform-providers/terraform-provider-aws [no test files] ok github.com/terraform-providers/terraform-provider-aws/aws 1.313s $ go1.12 build $ ``` Passes unit testing, linting, smoke acceptance testing, and release process cross-compilation testing. ```console $ TF_ACC=1 go test ./aws -v -timeout 120m -parallel 20 -run='TestAccAWSProvider' ... --- PASS: TestAccAWSProvider_Region_AwsCommercial (2.58s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.59s) --- PASS: TestAccAWSProvider_Region_AwsChina (2.60s) --- PASS: TestAccAWSProvider_Endpoints_Deprecated (2.72s) --- PASS: TestAccAWSProvider_Endpoints (2.80s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 3.846s $ gox -os='linux darwin windows freebsd openbsd solaris' -arch='386 amd64 arm' -osarch='!darwin/arm !darwin/386' -ldflags '-s -w -X aws/version.ProviderVersion=99.99.99 -X aws/version.ProtocolVersion=4' -output 'results/{{.OS}}_{{.Arch}}/terraform-provider-aws_v99.99.99_x4' . Number of parallel builds: 7 --> darwin/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/amd64: github.com/terraform-providers/terraform-provider-aws --> solaris/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/arm: github.com/terraform-providers/terraform-provider-aws --> windows/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/386: github.com/terraform-providers/terraform-provider-aws --> windows/386: github.com/terraform-providers/terraform-provider-aws --> freebsd/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/arm: github.com/terraform-providers/terraform-provider-aws --> openbsd/386: github.com/terraform-providers/terraform-provider-aws --> openbsd/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/386: github.com/terraform-providers/terraform-provider-aws ```
- Loading branch information
Showing
138 changed files
with
3,728 additions
and
9,235 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.