IrSO has mismatch between image and manifest versions

[lentzi90]

I noticed this while investigating a failed CI job. It is not the reason the job failed though.
After #1478, the IrSO image is pinned to a specific version. However, the manifests (and particularly the CRDs) are not. As of now, this mismatch is enough to make IrSO non-functional. We need to pin the commit for the IrSO manifests also.

The errors look like this:

2024-12-06T22:24:45Z	ERROR	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "IronicDatabase.metal3.io", "error": "no matches for kind \"IronicDatabase\" in version \"metal3.io/v1alpha1\""}
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1.1
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/source/kind.go:71
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func2
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/loop.go:87
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/loop.go:88
k8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/poll.go:33
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/source/kind.go:64
2024-12-06T22:24:45Z	ERROR	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "Ironic.metal3.io", "error": "no matches for kind \"Ironic\" in version \"metal3.io/v1alpha1\""}
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1.1
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/source/kind.go:71
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func2
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/loop.go:87
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/loop.go:88
k8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/poll.go:33
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/source/kind.go:64

Side note: We are installing IrSO even when not deploying Ironic this way. See

metal3-dev-env/03_launch_mgmt_cluster.sh

Lines 664 to 669 in b745d52

	launch_ironic_standalone_operator
	if [[ "${USE_IRSO}" == true ]]; then
	launch_ironic_via_irso
	else
	launch_ironic
	fi

It is not an issue, but something to be aware of in case it leads to confusion.

[lentzi90]

FYI @dtantsur

[Rozzii]

/triage accepted
/kind bug

[dtantsur]

Oh yeah, this was pretty dumb of me :-/ Will be fixed by #1488