Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minikube in Ubuntu based tests #1405

Open
1 of 3 tasks
kashifest opened this issue May 21, 2024 · 7 comments
Open
1 of 3 tasks

Use minikube in Ubuntu based tests #1405

kashifest opened this issue May 21, 2024 · 7 comments
Labels
triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@kashifest
Copy link
Member

kashifest commented May 21, 2024

Recently we have seen that CentOS E2Es are failing in different tests since the CI infra shift. In contrast, ubuntu e2es are rather stable. CentOS failures are mostly causing problems and main branch PRs which are left hanging for unrelated issues. There are few steps which we can perform the phase out CentOS tests for the time being:

  • Use minikube in Ubuntu to make sure ironic is deployed as k8s deployment instead of local containers as it is now. This is the fundamental difference currently between Ubuntu and CentOS tests - Make minikube the default ephemeral cluster #1404
  • Phase out CentOS tests as required from prow in project-infra repo as well github branch protection settings.
  • Bring back CentOS (if deemed necessary) once the CI infra has better hardware and tests are not flaky. CentOS periodics which are not being phased out can signal this.
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label May 21, 2024
@kashifest
Copy link
Member Author

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 21, 2024
@Rozzii Rozzii moved this from Backlog to MISC WIP in Metal3 - Roadmap Jun 28, 2024
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2024
@Rozzii
Copy link
Member

Rozzii commented Aug 28, 2024

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
@Rozzii
Copy link
Member

Rozzii commented Aug 28, 2024

@Sunnatillo @kashifest my memory is fogy about this wasn't there more progress on this one?

@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2024
@dtantsur
Copy link
Member

/remove-lifecycle stale

Starting Ironic locally will not be compatible with ironic-standalone-operator (unless metal3-io/ironic-standalone-operator#86 is done), so I highly vote for using minikube on Ubuntu as well.

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2024
@tuminoid
Copy link
Member

I guess the only argument keeping it off minikube is to simulate cases where Ironic is not installed in k8s, which has sometimes revealed some assumptions. This is of course not IRSO compatible, and it does not need to be. I agree with the maintenance burden though, so it should be considered if its worth it or not for the sake of testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Status: MISC WIP
Development

No branches or pull requests

5 participants