Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickity 2.3 + Fade 2.0 #17

Open
anteksiler opened this issue Mar 22, 2022 · 17 comments
Open

Flickity 2.3 + Fade 2.0 #17

anteksiler opened this issue Mar 22, 2022 · 17 comments

Comments

@anteksiler
Copy link

anteksiler commented Mar 22, 2022

Using flickity.pkgd.min.js + fade script throws the following error:

Cannot set properties of undefined (setting 'fade')

Test case: https://codepen.io/anteksiler/pen/QWadjXP

@AnInfiniteNumberofMonkeys
Copy link

AnInfiniteNumberofMonkeys commented Mar 29, 2022

I'm getting this too. It also happens with Flickity 2.2 + Face 2.0

@ewhicher
Copy link

Same here too, using latest package links:

<script src="https://unpkg.com/flickity@2/dist/flickity.pkgd.min.js"></script>
<script src="https://unpkg.com/flickity-fade@2/flickity-fade.js"></script>

@mark-chief
Copy link

Same for me..

	<link rel="stylesheet" href="https://unpkg.com/flickity@2/dist/flickity.min.css">
	<link rel="stylesheet" href="https://unpkg.com/flickity-fade@2/flickity-fade.css">
	<script src="https://unpkg.com/flickity@2/dist/flickity.pkgd.min.js"></script>
	<script src="https://unpkg.com/flickity-fade@2/flickity-fade.js"></script>

@troycartmill
Copy link

I'm getting same error. I'm using Flickity v2.2.1 + Face 2.0

@darinronne
Copy link

I am also experiencing this issue.
Fade v1 works with Flickity v2.2 and v2.3, but Fade v2 works with neither version of Flickity.

@anteksiler
Copy link
Author

Fade v1 is not working for me with Flickity 2.3

@anteksiler
Copy link
Author

@desandro Hi David, could you please look into this? I am not sure what the issue is.

@atlamors
Copy link

+1

@RYJASM
Copy link

RYJASM commented Jul 31, 2022

I am having this same issue.

@oxwebdevelopment
Copy link

+1

@Retroguru
Copy link

Same here. Would be nice to fix this :-)

@alphex
Copy link

alphex commented Oct 26, 2022

Downgrading to Flickity 2.2.0 with the Flickity-fade 1.0.0 release worked to solve the issue for me on a new build.

The release tags for flickity-fade say 2.0 is for the flickity 3 release. (see: https://github.com/metafizzy/flickity-fade/releases/tag/v2.0.0)

v2.0.0 for Flickity v3

@ewhicher
Copy link

@desandro any idea if you will be able to look at this any time soon?

Thanks!

@martinlandmeters
Copy link

+1

1 similar comment
@IndoPy
Copy link

IndoPy commented Feb 21, 2023

+1

@mhuegel
Copy link

mhuegel commented Mar 17, 2023

+1 but the solution from @alphex helped!

@dsoriano
Copy link

Use fade v1 with filckity v2 :

<script src="https://unpkg.com/flickity@2/dist/flickity.pkgd.min.js"></script>
<script src="https://unpkg.com/flickity-fade@1/flickity-fade.js"></script>

And don't forget not to use the wrapAround function, it works bad with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests