Apply perlimports to ./lib

oalders · oalders · commit d920607f7494 · 2024-09-03T08:45:32.000-04:00
diff --git a/app.psgi b/app.psgi
@@ -8,7 +8,7 @@ BEGIN {
 }
 use lib "$root_dir/lib";
 
-use Config::ZOMG;
+use Config::ZOMG          ();
 use File::Path            ();
 use File::Spec            ();
 use Log::Log4perl         ();
@@ -46,7 +46,7 @@ BEGIN {
     $SIG{__WARN__} = sub { $logger->warn(@_) };
 }
 
-use MetaCPAN::Server;
+use MetaCPAN::Server ();
 
 STDERR->autoflush;
 
diff --git a/bin/check_json.pl b/bin/check_json.pl
@@ -2,8 +2,8 @@
 # PODNAME: check_json.pl
 use 5.010;
 
-use Data::Dumper;
-use Cpanel::JSON::XS;
+use Data::Dumper     qw( Dumper );
+use Cpanel::JSON::XS qw( decode_json );
 
 foreach my $file (@ARGV) {
     say "Processing $file";
diff --git a/bin/convert_authors.pl b/bin/convert_authors.pl
@@ -2,8 +2,8 @@
 
 use strict;
 use warnings;
-use Cpanel::JSON::XS;
-use File::Find;
+use Cpanel::JSON::XS qw( decode_json );
+use File::Find       qw( find );
 
 my @files;
 find(
diff --git a/bin/metacpan b/bin/metacpan
@@ -14,9 +14,9 @@
 
 use strict;
 use warnings;
-use FindBin;
+use FindBin ();
 use lib "$FindBin::RealBin/../lib";
-use MetaCPAN::Script::Runner;
+use MetaCPAN::Script::Runner ();
 
 MetaCPAN::Script::Runner->run;
 
diff --git a/bin/unlisted_prereqs.pl b/bin/unlisted_prereqs.pl
@@ -6,9 +6,9 @@
 use strict;
 use warnings;
 use Perl::PrereqScanner 1.014;
-use CPAN::Meta::Requirements;
+use CPAN::Meta::Requirements ();
 use File::Find::Rule::Perl;
-use List::Util qw(sum);
+use List::Util qw( sum );
 use version 0.77;
 
 # TODO: use CPAN::Meta::Prereqs
@@ -91,7 +91,7 @@ sub check_prereqs {
     if version->parse( $reqs->{runtime}{perl} )
     <= version->parse($MIN_PERL_VERSION);
 
-use Data::Dumper;
+use Data::Dumper ();
 $Data::Dumper::Sortkeys = 1;
 print Data::Dumper->Dump( [$reqs], ['requires'] );
 
diff --git a/lib/Catalyst/Authentication/Store/Proxy.pm b/lib/Catalyst/Authentication/Store/Proxy.pm
@@ -2,7 +2,7 @@ package Catalyst::Authentication::Store::Proxy;
 
 # ABSTRACT: Delegates authentication logic to the user object
 use Moose;
-use Catalyst::Utils;
+use Catalyst::Utils           ();
 use MetaCPAN::Types::TypeTiny qw( HashRef Str );
 
 has user_class => (
diff --git a/lib/Catalyst/Plugin/Session/Store/ElasticSearch.pm b/lib/Catalyst/Plugin/Session/Store/ElasticSearch.pm
@@ -4,7 +4,7 @@ package Catalyst::Plugin::Session::Store::ElasticSearch;
 
 use Moose;
 extends 'Catalyst::Plugin::Session::Store';
-use MooseX::Types::ElasticSearch qw(:all);
+use MooseX::Types::ElasticSearch qw( ES );
 
 has _session_es => (
     required => 1,
diff --git a/lib/MetaCPAN/Document/Author.pm b/lib/MetaCPAN/Document/Author.pm
@@ -3,7 +3,7 @@ package MetaCPAN::Document::Author;
 use MetaCPAN::Moose;
 
 # load order important for next 2 modules
-use ElasticSearchX::Model::Document::Types qw(:all);
+use ElasticSearchX::Model::Document::Types qw( Location );
 use ElasticSearchX::Model::Document;
 
 # load order not important
diff --git a/lib/MetaCPAN/Document/Favorite.pm b/lib/MetaCPAN/Document/Favorite.pm
@@ -6,7 +6,7 @@ use warnings;
 use Moose;
 use ElasticSearchX::Model::Document;
 
-use DateTime;
+use DateTime ();
 use MetaCPAN::Util;
 
 has id => (
diff --git a/lib/MetaCPAN/Document/Release.pm b/lib/MetaCPAN/Document/Release.pm
@@ -2,7 +2,6 @@ package MetaCPAN::Document::Release;
 
 use Moose;
 
-use DateTime qw();
 use ElasticSearchX::Model::Document;
 use MetaCPAN::Types           qw( Dependency );
 use MetaCPAN::Types::TypeTiny qw(
@@ -293,7 +292,7 @@ sub set_first {
           # currently, the "first" property is not computed on all releases
           # since this feature has not been around when last reindexed
         ]
-    } )->count
+        } )->count
         ? 0
         : 1;
 
diff --git a/lib/MetaCPAN/Model/Archive.pm b/lib/MetaCPAN/Model/Archive.pm
@@ -5,7 +5,7 @@ use Moose;
 use MooseX::StrictConstructor;
 use MetaCPAN::Types::TypeTiny qw( AbsPath ArrayRef Bool Str );
 
-use Archive::Any;
+use Archive::Any ();
 use Carp         qw( croak );
 use Path::Tiny   qw( path );
 use Digest::file qw( digest_file_hex );
diff --git a/lib/MetaCPAN/Model/Release.pm b/lib/MetaCPAN/Model/Release.pm
@@ -15,9 +15,9 @@ use MetaCPAN::Types::TypeTiny qw( AbsPath ArrayRef Str );
 use MetaCPAN::Util            qw( fix_version);
 use Module::Metadata 1.000012 ();    # Improved package detection.
 use MooseX::StrictConstructor;
-use Path::Tiny qw( path );
-use Parse::PMFile;
-use Try::Tiny qw( catch try );
+use Path::Tiny    qw( path );
+use Parse::PMFile ();
+use Try::Tiny     qw( catch try );
 
 with 'MetaCPAN::Role::Logger';
 
diff --git a/lib/MetaCPAN/Model/User/Account.pm b/lib/MetaCPAN/Model/User/Account.pm
@@ -6,9 +6,8 @@ use warnings;
 use Moose;
 use ElasticSearchX::Model::Document;
 
-use MetaCPAN::Model::User::Identity ();
-use MetaCPAN::Types                 qw( Identity );
-use MetaCPAN::Types::TypeTiny       qw( ArrayRef Bool Dict Str );
+use MetaCPAN::Types           qw( Identity );
+use MetaCPAN::Types::TypeTiny qw( ArrayRef Bool Dict Str );
 use MetaCPAN::Util;
 
 =head1 PROPERTIES
diff --git a/lib/MetaCPAN/Pod/Renderer.pm b/lib/MetaCPAN/Pod/Renderer.pm
@@ -4,9 +4,9 @@ use MetaCPAN::Moose;
 
 use MetaCPAN::Pod::XHTML;
 use MetaCPAN::Types::TypeTiny qw( Uri );
-use Pod::Markdown;
-use Pod::Simple::JustPod ();
-use Pod::Text            ();
+use Pod::Markdown             ();
+use Pod::Simple::JustPod      ();
+use Pod::Text                 ();
 
 has perldoc_url_prefix => (
     is      => 'ro',
diff --git a/lib/MetaCPAN/Role/HasConfig.pm b/lib/MetaCPAN/Role/HasConfig.pm
@@ -6,7 +6,6 @@ use FindBin                   ();
 use Config::ZOMG              ();
 use MetaCPAN::Types::TypeTiny qw( HashRef );
 use MetaCPAN::Util            qw( checkout_root );
-use Module::Runtime           qw( require_module );
 
 # Done like this so can be required by a role
 sub config {
diff --git a/lib/MetaCPAN/Role/Script.pm b/lib/MetaCPAN/Role/Script.pm
@@ -2,7 +2,7 @@ package MetaCPAN::Role::Script;
 
 use Moose::Role;
 
-use ElasticSearchX::Model::Document::Types qw(:all);
+use ElasticSearchX::Model::Document::Types qw( ES );
 use MetaCPAN::Util                         qw( checkout_root );
 use Log::Contextual                        qw( :log :dlog );
 use MetaCPAN::Model                        ();
diff --git a/lib/MetaCPAN/Script/Backup.pm b/lib/MetaCPAN/Script/Backup.pm
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 use feature qw( state );
 
-use DateTime;
+use DateTime                  ();
 use IO::Zlib                  ();
 use Cpanel::JSON::XS          qw( decode_json encode_json );
 use Log::Contextual           qw( :log :dlog );
@@ -94,7 +94,7 @@ sub run_restore {
     my $self = shift;
 
     return log_fatal { $self->restore, q{ doesn't exist} }
-    unless ( -e $self->restore );
+        unless ( -e $self->restore );
     log_info { 'Restoring from ', $self->restore };
 
     my @bulk;
diff --git a/lib/MetaCPAN/Script/Latest.pm b/lib/MetaCPAN/Script/Latest.pm
@@ -5,10 +5,10 @@ use warnings;
 
 use Log::Contextual qw( :log );
 use Moose;
-use Parse::CPAN::Packages::Fast;
-use CPAN::DistnameInfo;
-use DateTime::Format::ISO8601 ();
-use MetaCPAN::Types::TypeTiny qw( Bool Str );
+use Parse::CPAN::Packages::Fast ();
+use CPAN::DistnameInfo          ();
+use DateTime::Format::ISO8601   ();
+use MetaCPAN::Types::TypeTiny   qw( Bool Str );
 
 with 'MetaCPAN::Role::Script', 'MooseX::Getopt';
 
diff --git a/lib/MetaCPAN/Script/Mirrors.pm b/lib/MetaCPAN/Script/Mirrors.pm
@@ -3,9 +3,8 @@ package MetaCPAN::Script::Mirrors;
 use strict;
 use warnings;
 
-use Cpanel::JSON::XS           ();
-use Log::Contextual            qw( :log :dlog );
-use MetaCPAN::Document::Mirror ();
+use Cpanel::JSON::XS ();
+use Log::Contextual  qw( :log :dlog );
 use Moose;
 
 with 'MetaCPAN::Role::Script', 'MooseX::Getopt';
diff --git a/lib/MetaCPAN/Script/Package.pm b/lib/MetaCPAN/Script/Package.pm
@@ -2,11 +2,10 @@ package MetaCPAN::Script::Package;
 
 use Moose;
 
-use CPAN::DistnameInfo          ();
-use IO::Uncompress::Gunzip      ();
-use Log::Contextual             qw( :log );
-use MetaCPAN::Document::Package ();
-use MetaCPAN::Types::TypeTiny   qw( Bool );
+use CPAN::DistnameInfo        ();
+use IO::Uncompress::Gunzip    ();
+use Log::Contextual           qw( :log );
+use MetaCPAN::Types::TypeTiny qw( Bool );
 
 with 'MooseX::Getopt', 'MetaCPAN::Role::Script';
 
diff --git a/lib/MetaCPAN/Script/Permission.pm b/lib/MetaCPAN/Script/Permission.pm
@@ -2,10 +2,9 @@ package MetaCPAN::Script::Permission;
 
 use Moose;
 
-use Log::Contextual                qw( :log );
-use MetaCPAN::Document::Permission ();
-use MetaCPAN::Types::TypeTiny      qw( Bool );
-use PAUSE::Permissions             ();
+use Log::Contextual           qw( :log );
+use MetaCPAN::Types::TypeTiny qw( Bool );
+use PAUSE::Permissions        ();
 
 with 'MooseX::Getopt', 'MetaCPAN::Role::Script';
 
diff --git a/lib/MetaCPAN/Script/Release.pm b/lib/MetaCPAN/Script/Release.pm
@@ -14,8 +14,7 @@ use MetaCPAN::Script::Runner  ();
 use MetaCPAN::Types::TypeTiny qw( Bool HashRef Int Str );
 use Moose;
 use PerlIO::gzip;
-use Try::Tiny  qw( catch try );
-use Path::Tiny qw(path);
+use Try::Tiny qw( catch try );
 
 with 'MetaCPAN::Role::Script', 'MooseX::Getopt',
     'MetaCPAN::Script::Role::Contributor';
diff --git a/lib/MetaCPAN/Script/Runner.pm b/lib/MetaCPAN/Script/Runner.pm
@@ -5,7 +5,7 @@ use warnings;
 
 use Config::ZOMG        ();
 use File::Path          ();
-use Hash::Merge::Simple qw(merge);
+use Hash::Merge::Simple qw( merge );
 use Module::Pluggable search_path => ['MetaCPAN::Script'];
 use Module::Runtime ();
 use Try::Tiny       qw( catch try );
diff --git a/lib/MetaCPAN/Script/Session.pm b/lib/MetaCPAN/Script/Session.pm
@@ -3,7 +3,7 @@ package MetaCPAN::Script::Session;
 use strict;
 use warnings;
 
-use DateTime;
+use DateTime ();
 use Moose;
 
 with 'MetaCPAN::Role::Script', 'MooseX::Getopt';
diff --git a/lib/MetaCPAN/Script/Tickets.pm b/lib/MetaCPAN/Script/Tickets.pm
@@ -6,13 +6,12 @@ use namespace::autoclean;
 # Some issue with rt.cpan.org's cert
 $ENV{PERL_LWP_SSL_VERIFY_HOSTNAME} = 0;
 
-use HTTP::Request::Common     qw( GET );
-use Log::Contextual           qw( :log :dlog );
-use MetaCPAN::Types::TypeTiny ();
-use Text::CSV_XS              ();
-use Net::GitHub::V4           ();
-use Ref::Util                 qw( is_hashref is_ref );
-use URI::Escape               qw( uri_escape );
+use HTTP::Request::Common qw( GET );
+use Log::Contextual       qw( :log :dlog );
+use Text::CSV_XS          ();
+use Net::GitHub::V4       ();
+use Ref::Util             qw( is_hashref is_ref );
+use URI::Escape           qw( uri_escape );
 
 with 'MetaCPAN::Role::Script', 'MooseX::Getopt';
 
@@ -231,7 +230,7 @@ sub parse_tsv {
             source => $self->rt_dist_url( $row->{dist} ),
             active => $row->{active},
             closed => $row->{inactive},
-            map      { $_ => $row->{$_} + 0 }
+            map { $_ => $row->{$_} + 0 }
                 grep { not /^(dist|active|inactive)$/ }
                 keys %$row,
         };
diff --git a/lib/MetaCPAN/Script/Watcher.pm b/lib/MetaCPAN/Script/Watcher.pm
@@ -4,9 +4,9 @@ use strict;
 use warnings;
 use Moose;
 
-use CPAN::DistnameInfo;
-use Cpanel::JSON::XS qw( decode_json );
-use Log::Contextual  qw( :log );
+use CPAN::DistnameInfo ();
+use Cpanel::JSON::XS   qw( decode_json );
+use Log::Contextual    qw( :log );
 use MetaCPAN::Util;
 use MetaCPAN::Types::TypeTiny qw( Bool );
 
diff --git a/lib/MetaCPAN/Server.pm b/lib/MetaCPAN/Server.pm
@@ -4,11 +4,10 @@ use Moose;
 
 ## no critic (Modules::RequireEndWithOne)
 use Catalyst qw( +MetaCPAN::Role::Fastly::Catalyst ), '-Log=warn,error,fatal';
-use Digest::SHA ();
-use Log::Log4perl::Catalyst;
-use Plack::Builder qw( builder enable );
-use Plack::Middleware::ReverseProxy;
-use Ref::Util qw( is_arrayref is_hashref );
+use Digest::SHA             ();
+use Log::Log4perl::Catalyst ();
+use Plack::Builder          qw( builder enable );
+use Ref::Util               qw( is_arrayref is_hashref );
 
 extends 'Catalyst';
 
diff --git a/lib/MetaCPAN/Server/Action/Deserialize.pm b/lib/MetaCPAN/Server/Action/Deserialize.pm
@@ -1,7 +1,6 @@
 package MetaCPAN::Server::Action::Deserialize;
 use Moose;
 extends 'Catalyst::Action::Deserialize';
-use Cpanel::JSON::XS qw(encode_json);
 
 around serialize_bad_request => sub {
     my $orig = shift;
diff --git a/lib/MetaCPAN/Server/Controller.pm b/lib/MetaCPAN/Server/Controller.pm
@@ -3,10 +3,7 @@ package MetaCPAN::Server::Controller;
 use Moose;
 use namespace::autoclean;
 
-use Cpanel::JSON::XS          ();
-use Moose::Util               ();
-use MetaCPAN::Types::TypeTiny qw( HashRef );
-use MetaCPAN::Util            qw( single_valued_arrayref_to_scalar );
+use MetaCPAN::Util qw( single_valued_arrayref_to_scalar );
 
 BEGIN { extends 'Catalyst::Controller'; }
 
diff --git a/lib/MetaCPAN/Server/Controller/File.pm b/lib/MetaCPAN/Server/Controller/File.pm
@@ -3,7 +3,6 @@ package MetaCPAN::Server::Controller::File;
 use strict;
 use warnings;
 
-use ElasticSearchX::Model::Util;
 use Moose;
 use MetaCPAN::Util qw( single_valued_arrayref_to_scalar );
 
diff --git a/lib/MetaCPAN/Server/Controller/Source.pm b/lib/MetaCPAN/Server/Controller/Source.pm
@@ -4,8 +4,8 @@ use strict;
 use warnings;
 
 use Moose;
-use Plack::App::Directory;
-use Plack::MIME;
+use Plack::App::Directory ();
+use Plack::MIME           ();
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 
diff --git a/lib/MetaCPAN/Server/Controller/User.pm b/lib/MetaCPAN/Server/Controller/User.pm
diff --git a/lib/MetaCPAN/Server/Controller/User/Turing.pm b/lib/MetaCPAN/Server/Controller/User/Turing.pm
diff --git a/lib/MetaCPAN/Server/Diff.pm b/lib/MetaCPAN/Server/Diff.pm
diff --git a/lib/MetaCPAN/Types/Internal.pm b/lib/MetaCPAN/Types/Internal.pm
diff --git a/t/document/file.t b/t/document/file.t
diff --git a/xt/search_web.t b/xt/search_web.t

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ BEGIN {`
`8`	`8`	`}`
`9`	`9`	`use lib "$root_dir/lib";`
`10`	`10`
`11`		`-use Config::ZOMG;`
	`11`	`+use Config::ZOMG ();`
`12`	`12`	`use File::Path ();`
`13`	`13`	`use File::Spec ();`
`14`	`14`	`use Log::Log4perl ();`
`@@ -46,7 +46,7 @@ BEGIN {`
`46`	`46`	`$SIG{__WARN__} = sub { $logger->warn(@_) };`
`47`	`47`	`}`
`48`	`48`
`49`		`-use MetaCPAN::Server;`
	`49`	`+use MetaCPAN::Server ();`
`50`	`50`
`51`	`51`	`STDERR->autoflush;`
`52`	`52`