Keep test data out of t directory.

Author: oalders

etc/metacpan_testing.pl

@@ -3,8 +3,8 @@
     port => '5900',
     die_on_error => 1,
     level => ($ENV{TEST_VERBOSE} ? 'info' : 'warn'),
-    cpan => 't/var/tmp/fakecpan',
-    source_base => 't/var/tmp/source',
+    cpan => 'var/t/tmp/fakecpan',
+    source_base => 'var/t/tmp/source',
     logger => [{
         class => 'Log::Log4perl::Appender::Screen',
         name => 'testing'

t/00_setup.t

@@ -4,10 +4,16 @@ use warnings;
 use lib 't/lib';
 
 use CPAN::Faker 0.010;
+use Devel::Confess;
 use File::Copy;
 use MetaCPAN::Script::Tickets;
 use MetaCPAN::Server::Test;
-use MetaCPAN::TestHelpers qw( get_config );
+use MetaCPAN::TestHelpers qw(
+    fakecpan_configs_dir
+    fakecpan_dir
+    get_config
+    tmp_dir
+);
 use MetaCPAN::TestServer;
 use Module::Faker 0.015 ();    # Generates META.json.
 use Path::Class qw(dir);
@@ -16,12 +22,7 @@ use Test::More 0.96;
 use Test::More 0.96 ();
 use Test::Most;
 
-my $tmp_dir = dir('var/tmp');
-
-unless ( -d $tmp_dir || -l $tmp_dir ) {
-    $tmp_dir->mkpath();
-}
-ok( ( -d $tmp_dir || -l $tmp_dir ), 'var/tmp exists for testing' );
+ok( ( -d tmp_dir() ), 'var/tmp exists for testing' );
 
 my $server = MetaCPAN::TestServer->new;
 $server->setup;
@@ -40,19 +41,26 @@ foreach my $test_dir ( $config->{cpan}, $config->{source_base} ) {
 my $mod_faker = 'Module::Faker::Dist::WithPerl';
 eval "require $mod_faker" or die $@;    ## no critic (StringyEval)
 
+my $fakecpan_dir = fakecpan_dir();
+$fakecpan_dir->rmtree;
+$fakecpan_dir = fakecpan_dir();         # recreate dir
+
+my $fakecpan_configs = fakecpan_configs_dir();
+
 my $cpan = CPAN::Faker->new(
     {
-        source     => 't/var/fakecpan/configs',
-        dest       => $config->{cpan},
+        source     => $fakecpan_configs->subdir('configs')->stringify,
+        dest       => $fakecpan_dir->stringify,
         dist_class => $mod_faker,
     }
 );
 
 ok( $cpan->make_cpan, 'make fake cpan' );
+$fakecpan_dir->subdir('authors')->mkpath;
 
 # do some changes to 06perms.txt
 {
-    my $perms_file = dir( $config->{cpan} )->file(qw(modules 06perms.txt));
+    my $perms_file = $fakecpan_dir->subdir('modules')->file('06perms.txt');
     my $perms      = $perms_file->slurp;
     $perms =~ s/^Some,LOCAL,f$/Some,MO,f/m;
     my $fh = $perms_file->openw;
@@ -64,29 +72,29 @@ ok( $cpan->make_cpan, 'make fake cpan' );
 require Parse::PMFile;
 local $Parse::PMFile::VERBOSE = $ENV{TEST_VERBOSE} ? 9 : 0;
 
-$server->index_releases;
-$server->set_latest;
-
-my $cpan_dir = dir( 't', 'var', 'fakecpan', );
+my $src_dir = $fakecpan_configs;
 
-copy( $cpan_dir->file('00whois.xml'),
-    file( $config->{cpan}, qw(authors 00whois.xml) ) );
+$src_dir->file('00whois.xml')
+    ->copy_to( $fakecpan_dir->file(qw(authors 00whois.xml)) );
 
-copy( $cpan_dir->file('author-1.0.json'),
-    file( $config->{cpan}, qw(authors id M MO MO author-1.0.json) ) );
+copy( $src_dir->file('author-1.0.json'),
+    $fakecpan_dir->file(qw(authors id M MO MO author-1.0.json)) );
 
-copy( $cpan_dir->file('bugs.tsv'), file( $config->{cpan}, 'bugs.tsv' ) );
+copy( $src_dir->file('bugs.tsv'), $fakecpan_dir->file('bugs.tsv') );
 
+$server->index_releases;
+$server->set_latest;
 $server->index_authors;
+$server->index_cpantesters;
 
 ok(
     MetaCPAN::Script::Tickets->new_with_options(
         {
             %{$config},
             rt_summary_url => 'file://'
-                . file( $config->{cpan}, 'bugs.tsv' )->absolute,
+                . $fakecpan_dir->file('bugs.tsv')->absolute,
             github_issues => 'file://'
-                . dir(qw(t var fakecpan github))->absolute
+                . $fakecpan_dir->subdir('github')->absolute
                 . '/%s/%s.json?per_page=100',
         }
         )->run,

t/lib/MetaCPAN/DarkPAN.pm

@@ -1,13 +1,11 @@
 package MetaCPAN::DarkPAN;
 
-use strict;
-use warnings;
+use MetaCPAN::Moose;
 
 use CPAN::Repository::Perms;
 use MetaCPAN::TestHelpers qw( get_config );
 use MetaCPAN::Types qw( Dir );
 use MetaCPAN::Util qw( author_dir );
-use Moose;
 use OrePAN2::Indexer;
 use OrePAN2::Injector;
 use Path::Class qw( dir );

t/lib/MetaCPAN/TestHelpers.pm

@@ -16,15 +16,18 @@ use Try::Tiny qw( catch try );
 use base 'Exporter';
 our @EXPORT = qw(
     catch
-    get_config
     decode_json_ok
     encode_json
+    fakecpan_configs_dir
+    fakecpan_dir
     finally
+    get_config
     hex_escape
     multiline_diag
     run_tests
     test_distribution
     test_release
+    tmp_dir
     try
 );
 
@@ -100,4 +103,23 @@ sub get_config {
     return $config;
 }
 
+sub tmp_dir {
+    my $dir = dir( undef, checkout_root(), 'var', 't', 'tmp' );
+    $dir->mkpath;
+    return $dir;
+}
+
+sub fakecpan_dir {
+    my $dir      = tmp_dir();
+    my $fakecpan = $dir->subdir('fakecpan');
+    $fakecpan->mkpath;
+    return $fakecpan;
+}
+
+sub fakecpan_configs_dir {
+    my $source = dir( undef, checkout_root(), 'test-data', 'fakecpan' );
+    $source->mkpath;
+    return $source;
+}
+
 1;

t/lib/MetaCPAN/TestServer.pm

@@ -8,7 +8,7 @@ use MetaCPAN::Script::CPANTesters ();
 use MetaCPAN::Script::Latest;
 use MetaCPAN::Script::Mapping;
 use MetaCPAN::Script::Release;
-use MetaCPAN::TestHelpers qw( get_config );
+use MetaCPAN::TestHelpers qw( get_config fakecpan_dir );
 use MetaCPAN::Types qw( Dir HashRef Str );
 use Search::Elasticsearch;
 use Search::Elasticsearch::TestServer;
@@ -48,7 +48,7 @@ has _cpan_dir => (
     isa      => Dir,
     init_arg => 'cpan_dir',
     coerce   => 1,
-    default  => 't/var/tmp/fakecpan',
+    default  => sub { fakecpan_dir() },
 );
 
 sub setup {

t/model/archive.t

@@ -3,6 +3,7 @@
 use strict;
 use warnings;
 
+use MetaCPAN::TestHelpers qw( fakecpan_dir );
 use Test::Most;
 
 my $CLASS = 'MetaCPAN::Model::Archive';
@@ -29,10 +30,10 @@ subtest 'archive extraction' => sub {
         'Some-1.00-TRIAL/MANIFEST'    => 62,
     );
 
-    my $archive
-        = $CLASS->new( file =>
-            't/var/tmp/fakecpan/authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz'
-        );
+    my $archive = $CLASS->new(
+        file => fakecpan_dir->file(
+            '/authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz')
+    );
 
     ok !$archive->is_impolite;
     ok !$archive->is_naughty;
@@ -51,10 +52,10 @@ subtest 'temp cleanup' => sub {
     my $tempdir;
 
     {
-        my $archive
-            = $CLASS->new( file =>
-                't/var/tmp/fakecpan/authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz'
-            );
+        my $archive = $CLASS->new(
+            file => fakecpan_dir->file(
+                'authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz')
+        );
 
         $tempdir = $archive->extract;
         ok -d $tempdir;
@@ -68,10 +69,10 @@ subtest 'temp cleanup' => sub {
 };
 
 subtest 'extract once' => sub {
-    my $archive
-        = $CLASS->new( file =>
-            't/var/tmp/fakecpan/authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz'
-        );
+    my $archive = $CLASS->new(
+        file => fakecpan_dir->file(
+            'authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz')
+    );
 
     is $archive->extract, $archive->extract;
 };
@@ -81,8 +82,8 @@ subtest 'set extract dir' => sub {
 
     {
         my $archive = $CLASS->new(
-            file =>
-                't/var/tmp/fakecpan/authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz',
+            file => facecpan_dir->file(
+                'authors/id/L/LO/LOCAL/Some-1.00-TRIAL.tar.gz'),
             extract_dir => $temp->dirname
         );
 

t/model/release/dependencies.t

@@ -4,14 +4,15 @@ use warnings;
 use FindBin;
 use MetaCPAN::Model::Release;
 use MetaCPAN::Script::Runner;
-use MetaCPAN::TestHelpers qw( get_config );
+use MetaCPAN::TestHelpers qw( fakecpan_dir get_config );
 use Test::Most;
 
 my $config = get_config();
 
 subtest 'basic dependencies' => sub {
     my $file
-        = 't/var/tmp/fakecpan/authors/id/M/MS/MSCHWERN/Prereqs-Basic-0.01.tar.gz';
+        = fakecpan_dir->file(
+        '/authors/id/M/MS/MSCHWERN/Prereqs-Basic-0.01.tar.gz');
 
     my $release = MetaCPAN::Model::Release->new(
         logger => $config->{logger},

t/model/release/metadata.t

@@ -4,10 +4,10 @@ use warnings;
 use FindBin;
 use MetaCPAN::Model::Release;
 use MetaCPAN::Script::Runner;
-use MetaCPAN::TestHelpers qw( get_config );
+use MetaCPAN::TestHelpers qw( fakecpan_dir get_config );
 use Test::More;
 
-my $authordir = 't/var/tmp/fakecpan/authors/id/L/LO/LOCAL';
+my $authordir = fakecpan_dir->file('authors/id/L/LO/LOCAL');
 
 my $config = get_config();