Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test architecture #10

Closed
georgkrause opened this issue Jan 25, 2024 · 3 comments
Closed

Test architecture #10

georgkrause opened this issue Jan 25, 2024 · 3 comments

Comments

@georgkrause
Copy link
Collaborator

Currently the project uses python native unittest to run tests. I do see some issues with the current implementation and suggest to migrate to pytest. There are several reasons:

  • Other metabrainz projects seem to use pytest, so it helps using the same tech everywhere
  • We need parametrized tests. This isn't natively supported by unittest
    • Our current workaround is to manually build suits to pass test data as parameter
    • This way we disable automatic discovery, which is problematic because new tests need to be manually disabled (might result in false positives!)
    • Another workaround would be using a unittest extension, and if we do this we can use pytest right away
@georgkrause
Copy link
Collaborator Author

Pytest also has more capabilities when it comes to reporting

@ShashankSrivastava2002
Copy link

hello @georgkrause sir. Sir I want to work on this issue. Can you assign me this. also want to talk to you about the problem in way more detail.

@georgkrause
Copy link
Collaborator Author

I think @mayhem already solved this in #11 and this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants