Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated handler #52

Open
epels opened this issue Sep 28, 2018 · 0 comments
Open

Remove usage of deprecated handler #52

epels opened this issue Sep 28, 2018 · 0 comments
Milestone

Comments

@epels
Copy link
Contributor

epels commented Sep 28, 2018

In cmd/sachet/main.go, the deprecated prometheus.Handler() is used.

See: https://godoc.org/github.com/prometheus/client_golang/prometheus#Handler

The docs suggest using promhttp.Handler instead, but that seems to behave slightly different from prometheus.Handler.

Some related discussions in other repos:

@epels epels added this to the v1.0.0 milestone Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant