Skip to content

Commit 8b2295b

Browse files
authored
Webhook signature jwt (#87)
* Add implementation of the webhook signature JWT. * Update the linter. * Fix all lint errors and some lint warnings. * Add GH Actions.
1 parent 5119af8 commit 8b2295b

40 files changed

+3432
-371
lines changed

.eslintrc

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,17 @@
11
{
2-
"ecmaFeatures": {
3-
"modules": true
4-
},
5-
2+
"extends": "eslint:recommended",
63
"env": {
7-
"node": true
4+
"node": true,
5+
"es6": true
86
},
9-
107
"rules": {
118
"array-bracket-spacing": [2, "never"],
129
"brace-style": [2, "1tbs", { "allowSingleLine": true }],
1310
"camelcase": 0,
1411
"comma-spacing": [2, { "before": false, "after": true }],
1512
"comma-style": [2, "last"],
1613
"comma-dangle": [2, "never"],
17-
"complexity": [1, 8],
14+
"complexity": [1, 10],
1815
"computed-property-spacing": [2, "never"],
1916
"consistent-return": 1,
2017
"curly": [2, "all"],
@@ -96,7 +93,7 @@
9693
"no-undef": 2,
9794
"no-undef-init": 2,
9895
"no-undefined": 2,
99-
"no-underscore-dangle": 2,
96+
"no-underscore-dangle": [2, {"allow": ["_links", "_extend"]}],
10097
"no-unexpected-multiline": 2,
10198
"no-unneeded-ternary": 2,
10299
"no-unreachable": 2,
@@ -121,15 +118,14 @@
121118
"before": false,
122119
"after": true
123120
}],
124-
"space-after-keywords": [2, "always"],
121+
"keyword-spacing": 2,
125122
"space-before-blocks": [2, "always"],
126123
"space-before-function-paren": [2, {
127124
"anonymous": "always",
128125
"named": "never"
129126
}],
130127
"space-in-parens": [2, "never"],
131128
"space-infix-ops": 2,
132-
"space-return-throw-case": 2,
133129
"space-unary-ops": [2, {
134130
"words": true,
135131
"nonwords": false

.github/test.yml

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
name: test
2+
on:
3+
push:
4+
branches:
5+
- '*'
6+
- '!master'
7+
workflow_dispatch: {}
8+
9+
jobs:
10+
lint:
11+
runs-on: ubuntu-latest
12+
name: NodeJS ${{ matrix.node }} lint
13+
steps:
14+
- uses: actions/checkout@v2
15+
- name: Setup nodejs
16+
uses: actions/setup-node@v2
17+
with:
18+
node-version: '18'
19+
- run: npm install
20+
- run: npm run dtslint
21+
test:
22+
runs-on: ubuntu-latest
23+
strategy:
24+
matrix:
25+
node: [ '10','11', '12', '13', '14', '15', '16', '17', '18']
26+
name: NodeJS ${{ matrix.node }} test
27+
env:
28+
MB_ACCESSKEY: test_iQpAp0KCs5GCsMpDhIx2leuNB
29+
steps:
30+
- uses: actions/checkout@v2
31+
- name: Setup nodejs
32+
uses: actions/setup-node@v2
33+
with:
34+
node-version: ${{ matrix.node }}
35+
- run: npm install
36+
- run: npm run test

.travis.yml

Lines changed: 0 additions & 12 deletions
This file was deleted.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Let's go ahead and initialize the library first. Don't forget to replace `<YOUR_
2727
CommonJS require syntax:
2828

2929
```javascript
30-
var messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
30+
const messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
3131
```
3232

3333
Typescript with ES6 import (or .mjs with Node >= v13):

examples/balance.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
var messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
2+
const messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
33

44
messagebird.balance.read(function (err, response) {
55
if (err) {

examples/calls.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
var messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
1+
const messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
22

33
// create a call
44
var params = {
5-
source: "<SOURCE_PHONE_NUMBER>",
6-
destination: "<DESTINATION_PHONE_NUMBER>",
5+
source: '<SOURCE_PHONE_NUMBER>',
6+
destination: '<DESTINATION_PHONE_NUMBER>',
77
callFlow: {
8-
title: "Say message",
8+
title: 'Say message',
99
steps: [
1010
{
11-
action: "say",
11+
action: 'say',
1212
options: {
13-
payload: "This is a journey into sound. Good bye!",
14-
voice: "male",
15-
language: "en-US"
13+
payload: 'This is a journey into sound. Good bye!',
14+
voice: 'male',
15+
language: 'en-US'
1616
}
1717
}
1818
]
@@ -21,31 +21,31 @@ var params = {
2121

2222
messagebird.calls.create(params, function (err, response) {
2323
if (err) {
24-
return console.log(err);
24+
return console.log(err);
2525
}
2626
console.log(response);
2727
});
2828

2929
// list calls
3030
messagebird.calls.list(function (err, response) {
3131
if (err) {
32-
return console.log(err);
32+
return console.log(err);
3333
}
3434
console.log(response);
3535
});
3636

3737
// read a call
38-
messagebird.calls.read('<CALL_ID>' ,function (err, response) {
38+
messagebird.calls.read('<CALL_ID>', function (err, response) {
3939
if (err) {
40-
return console.log(err);
40+
return console.log(err);
4141
}
4242
console.log(response);
4343
});
4444

4545
// delete a call
46-
messagebird.calls.delete('<CALL_ID>' ,function (err, response) {
46+
messagebird.calls.delete('<CALL_ID>', function (err, response) {
4747
if (err) {
48-
return console.log(err);
48+
return console.log(err);
4949
}
5050
console.log(response);
5151
});

examples/conversations.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11

2-
var messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
2+
const messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
33

44
// start a conversation
55
messagebird.conversations.start({
66
'to': '31612345678',
7-
'channelId': '619747f69cf940a98fb443140ce9aed2' ,
7+
'channelId': '619747f69cf940a98fb443140ce9aed2',
88
'type': 'text',
99
'content': { 'text': 'Hello!' }
1010
}, function (err, response) {
@@ -102,7 +102,7 @@ messagebird.conversations.webhooks.read('451e6b72799e4415b2aab425f582f65e', func
102102

103103
// update webhook
104104
messagebird.conversations.webhooks.update('451e6b72799e4415b2aab425f582f65e', {
105-
'status': 'disabled',
105+
'status': 'disabled'
106106
}, function (err, response) {
107107
if (err) {
108108
return console.log(err);

examples/hlr_create.js renamed to examples/hlr-create.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
var messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
2+
const messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
33

44
messagebird.hlr.create('31612345678', 'YourBrand', function (err, response) {
55
if (err) {

examples/hlr_read.js renamed to examples/hlr-read.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
var messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
2+
const messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
33

44
messagebird.hlr.read('<HLR_ID>', function (err, response) {
55
if (err) {

examples/lookup_hlr_create.js renamed to examples/lookup-hlr-create.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
var messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
2+
const messagebird = require('messagebird')('<YOUR_ACCESS_KEY>');
33

44
messagebird.lookup.hlr.create('31612345678', function (err, response) {
55
if (err) {

0 commit comments

Comments
 (0)