Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --fatal-meson-warnings to meson dist #13994

Open
matthiasclasen opened this issue Dec 9, 2024 · 1 comment
Open

Add --fatal-meson-warnings to meson dist #13994

matthiasclasen opened this issue Dec 9, 2024 · 1 comment

Comments

@matthiasclasen
Copy link

I am currently stuck trying to figure out why meson dist tells me "Dist currently only works with Git or Mercurial repos" when I run it in a git checkout in gitlab ci. The code around that unhinged comment in mdist.py does a few mlog.warning calls, but those never make it anywhere I could use them to find out what it doesn't like about the git checkout. This is very frustrating. If I could set --fatal-meson-warnings, or --verbose or somesuch, maybe I would not be this stuck.

@matthiasclasen
Copy link
Author

I also think that the error message is extremely poor. I was in a git repository, and your code is eating the one helpful error message (from git ls-files), only to tell me "Dist only works in a git repository". This cost me hours, since it only happens in ci. I would strongly recommend to prove the error reporting around this, to avoid angry users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant