Replies: 2 comments
-
# Standard parameters for meson builds.
sig { returns(T::Array[String]) }
def std_meson_args
["--prefix=#{prefix}", "--libdir=#{lib}", "--buildtype=release", "--wrap-mode=nofallback"]
end And in https://github.com/Homebrew/homebrew-core/blob/4ebc58b38d2960f746579e2072b05ce46bedfef4/Formula/rmw.rb#L34 this definition is reused: def install
mkdir "build" do
system "meson", *std_meson_args, ".."
system "ninja", "-v"
system "ninja", "install", "-v"
end
end It is of course the homebrew maintainers' choice to disable fallback wraps. They would probably rationalize this choice by saying it is to prevent formulas like rmw from using vendored versions of canfigger, when the homebrew way would be to add a formula for canfigger and include it as a The alternative would be to override the arguments used in the rmw formula, and specify a |
Beta Was this translation helpful? Give feedback.
-
They let me just add a formula for the library (even though it's not a notable GitHub repo yet), and all is well. |
Beta Was this translation helpful? Give feedback.
-
I was gonna update the rmw homebrew formula. After I changed the existing .rb file, I ran
brew install --build-from-source Formula/rmw.rb
brew
did its thing, and at the tail end of the output:I've included the source for canfigger in the rmw archive (I used 'dist --include-subprojects'). I've tested it on other systems, there's nothing wrong with how meson (or I) created the archive.
It appears that the folks at brew just don't allow the use of the fallback: keyword for some reason.
As for starting this discussion, I'm not reporting any issue with meson, but just wondering... wtf? Have any other maintainers experienced this when adding or updating their project in the Homebrew repo?
Beta Was this translation helpful? Give feedback.
All reactions