initNonce extraNonce position

[dizcza]

Shouldn't this line

firmware/src/mesh/CryptoEngine.cpp

Line 258 in 3a34f8b

memcpy(nonce + sizeof(uint32_t), &extraNonce, sizeof(uint32_t));

be

memcpy(nonce + sizeof(uint64_t) + sizeof(uint32_t), &extraNonce, sizeof(uint32_t));

?

[fifieldt]

@jp-bennett might know

[esev]

See also:

• [Feature Request]: CryptoEngine.cpp questions & suggestions #5543
• Clarify the nonce values/sizes #5613

[jp-bennett]

I definitely need to do some better documentation of this. The problem is that it is a mess, and we've had to work to keep it backwards compatible. The Packet ID is actually only 32 bits. I think the draft patch from @esev gets it right. I didn't have time to dive deeply into that when he posted it, and honestly forgot to go back and look again.

[dizcza]

I see. The draft PR clarified my question.

Well, it's been a month since it was created.