Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential reference to non-existent(?) functions #697

Closed
gs-101 opened this issue Dec 14, 2024 · 2 comments · Fixed by #703
Closed

Potential reference to non-existent(?) functions #697

gs-101 opened this issue Dec 14, 2024 · 2 comments · Fixed by #703

Comments

@gs-101
Copy link
Contributor

gs-101 commented Dec 14, 2024

meow/meow-command.el

Line 1565 in f74017c

(unless (member last-command '(meow-pop-to-mark-command meow-unpop-to-mark-command))

Sorry if I'm missing some context of the functionality of last-command, but wouldn't the correct version of this line be:

-  (unless (member last-command '(meow-pop-to-mark-command meow-unpop-to-mark-command))
+  (unless (member last-command '(meow-pop-to-mark meow-unpop-to-mark))

Since these commands don't have the -command suffix as part of their name?
@45mg 45mg mentioned this issue Dec 14, 2024
Merged
@gs-101 gs-101 changed the title Potential reference to (non-existent?) functions Potential reference to non-existent(?) functions Dec 18, 2024
@lostCat-31159
Copy link

I just started using Meow and was wondering why meow-pop-to-mark was clogging up the mark-ring with duplicates.
This fixed it for me.

@gs-101
Copy link
Contributor Author

gs-101 commented Dec 24, 2024

[...] This fixed it for me.

Great, I think I'll make a PR right now, I was waiting for #690 to be merged to make one as to not cause any issues.

gs-101 added a commit to gs-101/meow that referenced this issue Dec 24, 2024
@gs-101
Fix meow-pop-to-mark (meow-edit#697)
cc98f18 
Correctly reference the following commands:

* meow-pop-to-mark
* meow-unpop-to-mark
@gs-101 gs-101 mentioned this issue Dec 24, 2024
Merged
DogLooksGood added a commit that referenced this issue Dec 24, 2024
@gs-101 @DogLooksGood
Fix meow-pop-to-mark (#697) (#703)
af3f10e 
Correctly reference the following commands:

* meow-pop-to-mark
* meow-unpop-to-mark

Co-authored-by: tianshu <[email protected]>
jidibinlin pushed a commit to jidibinlin/meow that referenced this issue Jan 2, 2025
@gs-101 @DogLooksGood @jidibinlin
Fix meow-pop-to-mark (meow-edit#697) (meow-edit#703)
70b6e11 
Correctly reference the following commands:

* meow-pop-to-mark
* meow-unpop-to-mark

Co-authored-by: tianshu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix meow-pop-to-mark (#697) gs-101/meow
2 participants
@gs-101 @lostCat-31159